From: "Randy.Dunlap" <rddunlap@osdl.org>
To: maximilian attems <janitor@sternwelten.at>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>,
matt_domsch@dell.com
Subject: Re: [patch 3/3] efi eliminate bad section references
Date: Mon, 04 Apr 2005 14:45:41 -0700 [thread overview]
Message-ID: <4251B585.1080009@osdl.org> (raw)
In-Reply-To: <20050404181136.GC12394@sputnik.stro.at>
(adding Matt Domsch to cc:)
maximilian attems wrote:
> Randy please double check especially this one.
> there may be a better solution.
>
> Fix efi section references:
> remove __initdata for struct efi efi_phys
> and struct efi_memory_map memmap
'memmap' can be used after init, so remove __initdata from it
certainly looks correct to me.
Regarding efi_phys:
'efi_get_time' can be called after init (that "inline ... _init"
on it is confusing to me), and it calls phys_efi_get_time(),
which uses 'efi_phys', so efi_phys should not be marked
as __initdata.
OTOH, phys_efi_set_virtual_address_map() can be marked as __init.
You could add that as an efficiency measure.
so
Acked-by: Randy Dunlap <rddunlap@osdl.org>
> Error: ./arch/i386/kernel/efi.o .text refers to 000000d3 R_386_32
> .init.data
> Error: ./arch/i386/kernel/efi.o .text refers to 000000ff R_386_32
> .init.data
>
> efi_memmap_walk (which is not __init nor static)
> accesses both efi_phys and memmap.
>
> Signed-off-by: maximilian attems <janitor@sternwelten.at>
>
>
> --- linux-2.6.12-rc1-bk5/arch/i386/kernel/efi.c.orig 2005-04-04 19:41:13.109877906 +0200
> +++ linux-2.6.12-rc1-bk5/arch/i386/kernel/efi.c 2005-04-04 19:34:23.886343763 +0200
> @@ -46,8 +46,8 @@
>
> struct efi efi;
> EXPORT_SYMBOL(efi);
> -static struct efi efi_phys __initdata;
> -struct efi_memory_map memmap __initdata;
> +static struct efi efi_phys;
> +struct efi_memory_map memmap;
>
> /*
> * We require an early boot_ioremap mapping mechanism initially
--
~Randy
prev parent reply other threads:[~2005-04-04 21:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-04 18:11 [patch 3/3] efi eliminate bad section references maximilian attems
2005-04-04 21:45 ` Randy.Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4251B585.1080009@osdl.org \
--to=rddunlap@osdl.org \
--cc=akpm@osdl.org \
--cc=janitor@sternwelten.at \
--cc=linux-kernel@vger.kernel.org \
--cc=matt_domsch@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox