Re: 2.6.12-rc2-mm1

Christoph Hellwig
2005-04-05T09:13:26Z

On Tue, Apr 05, 2005 at 07:11:26PM +1000, Paul Mackerras wrote:
> Christoph Hellwig writes:
>
> > Those DRI callers aren't in mainline but introduced in bk-drm.patch,
> > looks like the DRI folks need beating with a big stick..
>
> Settle down Christoph, the compat_ioctl method is less than 3 months
> old, has only been in one official 2.6.x release, and isn't documented
> at all in the Documentation directory AFAICS. Don't be so impatient.

It's documented where the other filesystem entry points are documented.
This is not about beeing impatient but about adding APIs that at the same
time are actively removed all over the tree.

> Anyway, I did the 32-bit ioctl conversion stuff for the DRM. I'll
> look at changing it to use compat_ioctl. The big question of course
> is whether the DRM code will work correctly without the BKL held.

You can of course take the BKL inside your ->compat_ioctl method.