Re: [-mm patch] drivers/infiniband/hw/mthca/mthca_main.c: remove an unused label

Hal Rosenstock
2005-04-05T14:41:31Z

On Tue, 2005-04-05 at 10:24, Adrian Bunk wrote:
> On Tue, Apr 05, 2005 at 12:05:24AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.12-rc1-mm4:
> >...
> > +ib-mthca-add-support-for-new-mt25204-hca.patch
> >
> > Infiniband update
> >...
>
>
> This patch causes the following compile warning:
>
> <-- snip -->
>
> ...
> CC drivers/infiniband/hw/mthca/mthca_main.o
> drivers/infiniband/hw/mthca/mthca_main.c: In function `mthca_init_icm':
> drivers/infiniband/hw/mthca/mthca_main.c:479: warning: label
> `err_unmap_eqp' defined but not used
> ...
>
> <-- snip -->
>
>
> I'm not sure whether this patch to remove this label is correct, but if
> it isn't correct there must be a bug somewhere.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.12-rc2-mm1-full/drivers/infiniband/hw/mthca/mthca_main.c.old 2005-04-05 16:18:09.000000000 +0200
> +++ linux-2.6.12-rc2-mm1-full/drivers/infiniband/hw/mthca/mthca_main.c 2005-04-05 16:19:15.000000000 +0200
> @@ -475,8 +475,6 @@
>
> err_unmap_rdb:
> mthca_free_icm_table(mdev, mdev->qp_table.rdb_table);
> -
> -err_unmap_eqp:
> mthca_free_icm_table(mdev, mdev->qp_table.eqp_table);
>
> err_unmap_qp:

Roland caught this recently and there is a patch for this which will
sent upstream. The proper fix is different from this.

-- Hal