Re: [-mm patch] drivers/infiniband/hw/mthca/mthca_main.c: remove an unused label

Roland Dreier
2005-04-05T17:43:38Z

> CC drivers/infiniband/hw/mthca/mthca_main.o
> drivers/infiniband/hw/mthca/mthca_main.c: In function `mthca_init_icm':
> drivers/infiniband/hw/mthca/mthca_main.c:479: warning: label
> `err_unmap_eqp' defined but not used

Thanks, good catch. I screwed up the error path in that function a
little while merging patches. Here's the correct fix.

Correct unwinding in error path of mthca_init_icm().

Signed-off-by: Roland Dreier <roland@topspin.com>

--- linux-2.6.12-rc2-mm1.orig/drivers/infiniband/hw/mthca/mthca_main.c 2005-04-05 09:49:02.944473724 -0700
+++ linux-2.6.12-rc2-mm1/drivers/infiniband/hw/mthca/mthca_main.c 2005-04-05 09:49:15.679708865 -0700
@@ -437,7 +437,7 @@
if (!mdev->qp_table.rdb_table) {
mthca_err(mdev, "Failed to map RDB context memory, aborting\n");
err = -ENOMEM;
- goto err_unmap_rdb;
+ goto err_unmap_eqp;
}

mdev->cq_table.table = mthca_alloc_icm_table(mdev, init_hca->cqc_base,