Re: 2.6.12-rc2-mm1

Christoph Hellwig
2005-04-05T09:54:01Z

On Tue, Apr 05, 2005 at 07:44:38PM +1000, Paul Mackerras wrote:
> Christoph Hellwig writes:
>
> > - the magic CONFIG_COMPAT changes for SHM handles should only be done when
> > a module is set. CONFIG_COMPAT is set for mostly 64bit systems that can
> > run 32bit code and drm shouldn't behave differently just because we can
> > run 32bit code.
>
> Yes it should - we can have a 64-bit X server and a 32-bit DRI
> client. In this case the server will allocate a _DRM_SHM area and
> pass the handle to the client, which will then try to mmap the area.
> If we give a 64-bit handle to the server the client won't be able to
> access the area.

Please make it a module option so it doesn't regress everyone for your
specific needs.