From: Nick Piggin <nickpiggin@yahoo.com.au>
To: David Howells <dhowells@redhat.com>
Cc: Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>,
Russell King <rmk@arm.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR
Date: Fri, 08 Apr 2005 00:31:36 +1000 [thread overview]
Message-ID: <42554448.6080809@yahoo.com.au> (raw)
In-Reply-To: <19283.1112868864@redhat.com>
David Howells wrote:
> Hugh Dickins <hugh@veritas.com> wrote:
>
>
>>Remove use of FIRST_USER_PGD_NR from sys_mincore: it's inconsistent (no
>>other syscall refers to it), unnecessary (sys_mincore loops over vmas
>>further down) and incorrect (misses user addresses in ARM's first pgd).
>
>
> You should make it use FIRST_USER_ADDRESS instead. This check allows NULL
> pointers and suchlike to be weeded out before having to take the semaphore.
>
I'm not sure whether it is worth keeping the singular special
case here to slightly speed up what would probably be a bug in
a userspace program.
--
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2005-04-07 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-07 1:10 [PATCH 1/6] freepgt2: free_pgtables from FIRST_USER_ADDRESS Hugh Dickins
2005-04-07 1:13 ` [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR Hugh Dickins
2005-04-07 10:14 ` David Howells
2005-04-07 14:31 ` Nick Piggin [this message]
2005-04-08 3:40 ` Hugh Dickins
2005-04-07 1:14 ` [PATCH 3/6] freepgt2: arm FIRST_USER_ADDRESS PAGE_SIZE Hugh Dickins
2005-04-07 1:16 ` [PATCH 4/6] freepgt2: arm26 " Hugh Dickins
2005-04-07 2:22 ` Ian Molton
2005-04-07 1:18 ` [PATCH 5/6] freepgt2: arch FIRST_USER_ADDRESS 0 Hugh Dickins
2005-04-07 1:19 ` [PATCH 6/6] freepgt2: remove FIRST_USER_ADDRESS hack Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42554448.6080809@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox