From: Paulo Marques <pmarques@grupopie.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: RFC: turn kmalloc+memset(,0,) into kcalloc
Date: Fri, 08 Apr 2005 17:24:42 +0100 [thread overview]
Message-ID: <4256B04A.8070909@grupopie.com> (raw)
In-Reply-To: <20050408130008.GA6653@stusta.de>
Adrian Bunk wrote:
>[...]
>>>On Tue, Apr 05, 2005 at 05:26:31PM +0100, Paulo Marques wrote:
>>
>>Hi Adrian,
>
> Hi Paolo,
Paulo, please :)
Paolo is Spanish (or Italian), whereas Paulo is a Portuguese name.
>>[...]
>>I think most will agree that the second piece of code is more "readable".
>
> In this case yes (but it could still use the normal kcalloc).
Yes, but the cleanup is already just barely justifiable. 75% (or more)
of the calls will use just one parameter. Adding a stupid "1" to all of
those will make the cleanup even less worth while.
>[...]
> Joerg's list of recursions should be valid independent of the kernel
> version. Fixing any real stack problems [1] that might be in this list
> is a valuable task.
>
> And "make checkstack" in a kernel compiled with unit-at-a-time lists
> several possible problems at the top.
Ok, I've read Jörn's mail also and I think I can help out. It seems
however that there are more people working on this. Will it be better to
coordinate so we don't duplicate efforts or is the "everyone looks at
everything" approach better, so that its harder to miss something?
--
Paulo Marques - www.grupopie.com
All that is necessary for the triumph of evil is that good men do nothing.
Edmund Burke (1729 - 1797)
next prev parent reply other threads:[~2005-04-08 16:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-05 16:26 RFC: turn kmalloc+memset(,0,) into kcalloc Paulo Marques
2005-04-05 18:00 ` Jörn Engel
2005-04-06 12:09 ` Denis Vlasenko
2005-04-05 18:54 ` Jesper Juhl
2005-04-05 19:20 ` Roland Dreier
2005-04-05 20:01 ` Jesper Juhl
2005-04-06 11:28 ` Jörn Engel
2005-04-06 12:15 ` Paulo Marques
2005-04-06 13:10 ` Pekka Enberg
2005-04-06 15:50 ` Paulo Marques
2005-04-07 23:54 ` Kyle Moffett
2005-04-09 2:11 ` Jesper Juhl
2005-04-07 21:47 ` Adrian Bunk
2005-04-08 12:38 ` Paulo Marques
2005-04-08 13:00 ` Adrian Bunk
2005-04-08 13:20 ` Jörn Engel
2005-04-08 13:29 ` Adrian Bunk
2005-04-08 16:24 ` Paulo Marques [this message]
2005-04-08 19:43 ` Adrian Bunk
2005-04-08 19:49 ` Randy.Dunlap
2005-04-08 13:00 ` stack checking (was: Re: RFC: turn kmalloc+memset(,0,) into kcalloc) Jörn Engel
2005-04-09 14:19 ` RFC: turn kmalloc+memset(,0,) into kcalloc Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4256B04A.8070909@grupopie.com \
--to=pmarques@grupopie.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox