snd-ens1371 (alsa) & joystick woes

snd-ens1371 (alsa) & joystick woes

[Guillaume Chazarain]

Hi,

 From 2.6.11 to 2.6.12-rc2, there are some changes in the joystick behaviour
that I don't think are expected. It's a simple joystick using analog.ko 
plugged
on a sound board using snd-ens1371. So here we go:

With 2.6.11:
$ jstest /dev/input/js0
Joystick (Analog 3-axis 4-button joystick) has 3 axes and 4 buttons. 
Driver version is 2.1.0.
Testing ... (interrupt to exit)
Axes:  0: 32767  1:-32767  2:-32767 Buttons:  0:off  1:off  2:off  3:off

Works ok, button0 is the one that serves as a gun trigger. All buttons
work as expected when I use them.

$ jstest --event /dev/input/js0
Joystick (Analog 3-axis 4-button joystick) has 3 axes and 4 buttons. 
Driver version is 2.1.0.
Testing ... (interrupt to exit)
# ...
Event: type 1, time 201830, number 0, value 0
Event: type 1, time 202082, number 0, value 1
Event: type 1, time 202229, number 0, value 0
Event: type 1, time 202355, number 0, value 1
# ...

I repeatedly press the button0, works OK.

Now with 2.6.12-rc2:

$ jstest /dev/input/js0
Joystick (Analog 3-axis 4-button joystick) has 3 axes and 5 buttons. 
Driver version is 2.1.0.
Testing ... (interrupt to exit)
Axes:  0:     0  1:     0  2:-31874 Buttons:  0:off  1:off  2:off  
3:off  4:off

Huh, now it says it has 5 buttons. The button0 is disabled, and hitting
the gun trigger (button0 in 2.6.11) changes the button4. Others buttons
work as expected.


$ jstest --event /dev/input/js0
Joystick (Analog 3-axis 4-button joystick) has 3 axes and 5 buttons. 
Driver version is 2.1.0.
Testing ... (interrupt to exit)
# ...
Event: type 1, time -147737, number 4, value 0
Event: type 1, time -147170, number 4, value 1
Event: type 1, time -146991, number 4, value 0
Event: type 1, time -146834, number 4, value 1
Event: type 1, time -146676, number 4, value 0
Event: type 1, time -146529, number 4, value 1
Event: type 1, time -146361, number 4, value 0
Event: type 1, time -146193, number 4, value 1
Event: type 1, time -146004, number 4, value 0
Event: type 1, time -145836, number 4, value 1
Event: type 1, time -145710, number 4, value 0
Event: type 1, time -145385, number 4, value 1
Event: type 1, time -145269, number 4, value 0
# ...

Still playing with the gun trigger, the negative time must be the jiffies
initialisation to -300*HZ, but the number 4 seems wrong.

Thanks.

-- 
Guillaume

Re: snd-ens1371 (alsa) & joystick woes

[Patrick McFarland]

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

On Tuesday 12 April 2005 07:10 am, Guillaume Chazarain wrote:
> Hi,
>
>  From 2.6.11 to 2.6.12-rc2, there are some changes in the joystick
> behaviour that I don't think are expected. It's a simple joystick using
> analog.ko plugged
> on a sound board using snd-ens1371. So here we go:

I've had a running thread about snd-ens1371 issues. And I have no clue wtf is 
going on. On mine, it refuses to detect any joystick. Yet, my problem has 
been going on since _atleast_ 2.6.7. (atleast, from what I've seen.)

Something broke, and it broke hard. Speaking of which... is there anyone out 
there with a ens1371 that actually works right with joysticks?

-- 
Patrick "Diablo-D3" McFarland || pmcfarland@downeast.net
"Computer games don't affect kids; I mean if Pac-Man affected us as kids, we'd 
all be running around in darkened rooms, munching magic pills and listening to
repetitive electronic music." -- Kristian Wilson, Nintendo, Inc, 1989

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: snd-ens1371 (alsa) & joystick woes

[Guillaume Chazarain]

Patrick McFarland wrote:

>Something broke, and it broke hard. Speaking of which... is there anyone out 
>there with a ens1371 that actually works right with joysticks?
>  
>
I saw your thread, but I would say my case is less desperate than yours 
because my
joystick actually works a bit :-)
I have a problem only with the first button.

Regards.

-- 
Guillaume

Re: snd-ens1371 (alsa) & joystick woes

[Bodo Eggert <harvested.in.lkml@posting.7eggert.dyndns.org>]

Patrick McFarland <pmcfarland@downeast.net> wrote:

> Speaking of which... is there anyone out
> there with a ens1371 that actually works right with joysticks?

Yes, I'm using the oss driver.
-- 
Airstrikes always overshoot the target, artillery always falls short. 

Re: snd-ens1371 (alsa) & joystick woes

[Guillaume Chazarain]

Guillaume Chazarain wrote:

> From 2.6.11 to 2.6.12-rc2, there are some changes in the joystick 
> behaviour
> that I don't think are expected. It's a simple joystick using 
> analog.ko plugged
> on a sound board using snd-ens1371. So here we go:

Reverting 
http://linux.bkbits.net:8080/linux-2.5/diffs/drivers/input/joydev.c@1.31?nav=index.html|src/|src/drivers|src/drivers/input|hist/drivers/input/joydev.c
(removing all the added " + 1" in joydev.c) fixes it for me.

Regards.

-- 
Guillaume

Re: snd-ens1371 (alsa) & joystick woes

[Dmitry Torokhov]

On Friday 15 April 2005 04:36, Guillaume Chazarain wrote:
> Guillaume Chazarain wrote:
> 
> > From 2.6.11 to 2.6.12-rc2, there are some changes in the joystick 
> > behaviour
> > that I don't think are expected. It's a simple joystick using 
> > analog.ko plugged
> > on a sound board using snd-ens1371. So here we go:
> 
> Reverting 
> http://linux.bkbits.net:8080/linux-2.5/diffs/drivers/input/joydev.c@1.31?nav=index.html|src/|src/drivers|src/drivers/input|hist/drivers/input/joydev.c
> (removing all the added " + 1" in joydev.c) fixes it for me.
>

Hi,

Could you check if the following patch from Vojtech fixes it?
 
Thanks!

-- 
Dmitry


===================================================================


ChangeSet@1.2229.1.12, 2005-04-04 15:40:40+02:00, vojtech@suse.cz
  input: Fix button mapping in joydev - BTN_TRIGGER was being
         mapped twice, resulting in it being the last (instead
         of first) button on a joystick.
    
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>


 joydev.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


===================================================================



diff -Nru a/drivers/input/joydev.c b/drivers/input/joydev.c
--- a/drivers/input/joydev.c	2005-04-28 22:07:31 -05:00
+++ b/drivers/input/joydev.c	2005-04-28 22:07:31 -05:00
@@ -357,7 +357,7 @@
 }
 
 #ifdef CONFIG_COMPAT
-static long joydev_compat_ioctl(struct file *file, unsigned cmd, unsigned long arg)
+static long joydev_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 {
 	struct joydev_list *list = file->private_data;
 	struct joydev *joydev = list->joydev;
@@ -488,7 +488,7 @@
 			joydev->nkey++;
 		}
 
-	for (i = 0; i < BTN_JOYSTICK - BTN_MISC + 1; i++)
+	for (i = 0; i < BTN_JOYSTICK - BTN_MISC; i++)
 		if (test_bit(i + BTN_MISC, dev->keybit)) {
 			joydev->keymap[i] = joydev->nkey;
 			joydev->keypam[joydev->nkey] = i + BTN_MISC;

Re: snd-ens1371 (alsa) & joystick woes

[Guillaume Chazarain]

Dmitry Torokhov wrote:

>Could you check if the following patch from Vojtech fixes it?
>
As I said in http://bugzilla.kernel.org/show_bug.cgi?id=4382 yes it 
fixes the
problem.

Thanks.

-- 
Guillaume