public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paulo Marques <pmarques@grupopie.com>
To: Paulo Marques <pmarques@grupopie.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] create a kstrdup library function
Date: Wed, 13 Apr 2005 12:23:48 +0100	[thread overview]
Message-ID: <425D0144.9070207@grupopie.com> (raw)
In-Reply-To: <42519911.508@grupopie.com>

Paulo Marques wrote:
> Hi,
> 
> This patch creates a new kstrdup library function and changes the 
> "local" implementations in several places to use this function.

Arkadiusz Miskiewicz reported that this breaks compilation under PPC.

Apparently, PPC builds a bootloader that links against lib.a but doesn't 
expect any dependencies on slab. Since kstrdup calls kmalloc, this 
breaks compilation.

I can fix this by moving kstrdup into slab.c. This way this is treated 
as an "allocation" function instead of a string function, so it makes 
some sense to do this.

Andrew, do you prefer an incremental patch against the current tree, or 
a single clean patch against the current tree with all the current 
kstrdup patches taken out?

-- 
Paulo Marques - www.grupopie.com

All that is necessary for the triumph of evil is that good men do nothing.
Edmund Burke (1729 - 1797)

      parent reply	other threads:[~2005-04-13 11:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-04 19:44 [PATCH] create a kstrdup library function Paulo Marques
2005-04-04 21:15 ` Adrian Bunk
2005-04-05 11:17   ` Paulo Marques
2005-04-05 11:55     ` Paulo Marques
2005-04-04 21:49 ` Andres Salomon
2005-04-13 11:23 ` Paulo Marques [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=425D0144.9070207@grupopie.com \
    --to=pmarques@grupopie.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox