From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753027AbbJUKx5 (ORCPT ); Wed, 21 Oct 2015 06:53:57 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:58564 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbbJUKxz (ORCPT ); Wed, 21 Oct 2015 06:53:55 -0400 From: Arnd Bergmann To: glen lee Cc: linux-wireless@vger.kernel.org, Rachel Kim , devel@driverdev.osuosl.org, Chris Park , gregkh@linuxfoundation.org, Stanislav Kholmanskikh , Johnny Kim , linux-kernel@vger.kernel.org, Tony Cho , Leo Kim Subject: Re: [PATCH 00/19] staging/wilc1000 cleanups Date: Wed, 21 Oct 2015 12:53:48 +0200 Message-ID: <4261822.eWDaN5tlMP@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <562763BC.5030107@atmel.com> References: <1445381258-1455986-1-git-send-email-arnd@arndb.de> <562763BC.5030107@atmel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:IHGvznH6FoxanfLIpeIscyNHyaKb/ZVTfF1s0jG1jge1IJ0YUJS BBHgZPFyJ0W0EFD/REOL5Yi3eFBFINR+deMwf7LIM95MdmDXVpBeGQeVqP7ymE6Nj22vsg1 f66xpkxQVDisaI7AkwPPGpKFxAYKLKXGYpEz5jEbDnVDs8bZIgBIDn1SHvpTo7s9n3zEyBV hh2f1ehgaozmZKEHH3hYQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:H0ummaX6bZo=:N5LT8ORQ6YQELtOGgu2zxc lN/DRsG3bw5a2zpN/n7lLC0J4RuyowC+nZX2vdKVZgAcLCxVFNdA+AC1hfv2vY2EAu8qY9Izv zVn7OWt9P8QHUMjShGmcaOKbJlSYuxgfZSq437nGgfPX8asgbO6hmAW1BsslIgdwSJ0USO4Sp NcZWf5TkbYZU5jgoeQQ24IB/J/wbdm+KKfXqQSEZYszXcVkRkaan1Zu4KvYDiloZlfpAKQ6cC wRglBeivMZDKOU3r8BtmDv1ghbn60Lctpr3w9USojZxPBv8hkM/pmgXbOJn2QV40sB06Dv4FJ ZKsMrnxtJpUZT7TwXTk+8Wy3h+YVpaB5GGFy7pqr7LIR/AQpv3ypP3YttHEah+kxRb0pU3X8g UFj19aPGLh4K0wOM28/P9rg3U59wiYQ06y6kEAjqCXTJtK8FrXxMisWMB2VUn7azC5XWypdO/ JdnwPxs/X31Fi4/2bC7RFmsSygSKOgIWnJ+qhjzHE0dAHnzfk7RJ017nVyAWrsT19xeSZUMgU GVrkiLy3ZUHy/qPCpVpN5ZuWapkr0Pjm6r6S+3b6+HEih0IvjtcOm/PvMqc5QtZ7zB1g/wF7a b+ZoUzsPMsMSvjikqxlYLnW6uiciWEMVrwg+0+iCMJarWAjpdbDmzrvrKSN6iuacI3ZoQTSTJ vPaHlzY1qSYgC20op/fYgtTTHoQV6TiNFdWZnnqDBkvVHOq8jhY5hI5PYNqkMXJ4ULz1AHTPs qeWxTyRI6inKMnJm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 21 October 2015 19:06:52 glen lee wrote: > Hi arnd, > > Thanks for the all the patches. > About the patch ( use proper naming for global symbols ), > We are planning to use this driver not only for wilc1000 but also for > other atmel wireless driver. I'd appreciate if you could use wl instead of wilc1000. Hmm, while I see that 'wilc1000' is too specific here, using just 'wl' might be a little too general. The same namespace is used by drivers/mtd/ubi/wl.c, drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c, and a number of local identifiers in other drivers. Would 'wilc' work as a prefix for all devices you are interested in here? > And the global variable g_linux_wlan will be placed in netdevice private data > and finally it will be removed. I already posted some of those patches. Ok, so we need to coordinate a bit here. My patches also go in that direction and remove the global variables from linux_wlan_sdio.c and linux_wlan_spi.c, but did not remove the one from linux_wlan.c, because doing that depends on the last [RFC] patch in my series, and I felt I had spent enough time on it at that point ;-) Would you be ok with taking my patches and rebasing them on top of yours with the changes you want, or do you need help from me with that? Arnd