From: Andreas Steinmetz <ast@domdv.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
jmorris@redhat.com, davem@davemloft.net, ak@suse.de,
linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [RFC][PATCH 4/4] AES assembler implementation for x86_64
Date: Sun, 17 Apr 2005 22:24:00 +0200 [thread overview]
Message-ID: <4262C5E0.5070106@domdv.de> (raw)
In-Reply-To: <20050417195406.GC3625@stusta.de>
Adrian Bunk wrote:
> That is not specifically against this patch, but before we add another
> AES implementation, I'd like to find a better solution for the general
> AES selection.
That would be nice as I didn't like having to duplicate a whole Kconfig
entry which in fact means that it is triplicated now.
I'm fine with any solution here but I do believe whatever solution is
for the crypto maintainers to decide.
[snip]
>>+ depends on CRYPTO && (X86 && !X86_64)
>>+ depends on CRYPTO && X86 && !X86_64
>>...
>
>
> This doesn't make any difference.
>
> I think the former version was better readable, but that's no strong
> opinion.
This was only personal preference during development and actually you're
right, the former version is better readable.
--
Andreas Steinmetz SPAMmers use robotrap@domdv.de
prev parent reply other threads:[~2005-04-17 20:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-17 19:20 [RFC][PATCH 4/4] AES assembler implementation for x86_64 Andreas Steinmetz
2005-04-17 19:54 ` Adrian Bunk
2005-04-17 20:24 ` Andreas Steinmetz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4262C5E0.5070106@domdv.de \
--to=ast@domdv.de \
--cc=ak@suse.de \
--cc=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox