public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org, Dave Hansen <haveblue@us.ibm.com>,
	"Hariprasad Nellitheertha [imap]" <hari@in.ibm.com>
Subject: Re: [RFC][PATCH] nameing reserved pages [1/3]
Date: Thu, 21 Apr 2005 08:54:25 +0900	[thread overview]
Message-ID: <4266EBB1.1090806@jp.fujitsu.com> (raw)
In-Reply-To: <20050420211018.GC3372@elf.ucw.cz>

Hi!
Pavel Machek wrote:
>          ~
> 	  missing e?
Oh, it's typo :(. thanks!

> 
> 
>>+	Reserved_At_Boot,
>>+	Max_Reserved_Types,
>>+	Page_Invalid = 0xff
>>+};
> 
> 
> You certainly use unusual naming convention here. Could we get
> reserved_at_boot instead? (I.e. all lowercase).
> 
Okay.
> 
> 
>>+static inline void set_page_reserved(struct page *page, unsigned char type)
>>+{
> 
> 
> Make it enum page_type type.

I'll do.

Thanks
-- Kame <kamezawa.hiroyu@jp.fujitsu.com>


      reply	other threads:[~2005-04-20 23:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-20 12:08 [RFC][PATCH] nameing reserved pages [1/3] KAMEZAWA Hiroyuki
2005-04-20 21:10 ` Pavel Machek
2005-04-20 23:54   ` KAMEZAWA Hiroyuki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4266EBB1.1090806@jp.fujitsu.com \
    --to=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=hari@in.ibm.com \
    --cc=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox