From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754407AbaIKSSx (ORCPT ); Thu, 11 Sep 2014 14:18:53 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:35129 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752498AbaIKSSv (ORCPT ); Thu, 11 Sep 2014 14:18:51 -0400 From: Laurent Pinchart To: Philipp Zabel Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, Grant Likely , Greg Kroah-Hartman , Guennadi Liakhovetski , Mauro Carvalho Chehab , Russell King , kernel@pengutronix.de Subject: Re: [PATCH v3 5/8] of: Add of_graph_get_port_by_id function Date: Thu, 11 Sep 2014 21:18:52 +0300 Message-ID: <4267060.0lIyimHcqU@avalon> User-Agent: KMail/4.12.5 (Linux/3.14.14-gentoo; KDE/4.12.5; x86_64; ; ) In-Reply-To: <1410449587-1677-6-git-send-email-p.zabel@pengutronix.de> References: <1410449587-1677-1-git-send-email-p.zabel@pengutronix.de> <1410449587-1677-6-git-send-email-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp, Thank you for the patch. On Thursday 11 September 2014 17:33:04 Philipp Zabel wrote: > This patch adds a function to get a port device tree node by port id, > or reg property value. > > Signed-off-by: Philipp Zabel Acked-by: Laurent Pinchart > --- > Changes since v2: > - Fixed and simplified of_graph_get_port_by_id function > --- > drivers/of/base.c | 26 ++++++++++++++++++++++++++ > include/linux/of_graph.h | 7 +++++++ > 2 files changed, 33 insertions(+) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index a49b5628..76e2651 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -2053,6 +2053,32 @@ int of_graph_parse_endpoint(const struct device_node > *node, EXPORT_SYMBOL(of_graph_parse_endpoint); > > /** > + * of_graph_get_port_by_id() - get the port matching a given id > + * @parent: pointer to the parent device node > + * @id: id of the port > + * > + * Return: A 'port' node pointer with refcount incremented. The caller > + * has to use of_node_put() on it when done. > + */ > +struct device_node *of_graph_get_port_by_id(struct device_node *node, u32 > id) +{ > + struct device_node *port; > + > + for_each_child_of_node(node, port) { > + u32 port_id = 0; > + > + if (of_node_cmp(port->name, "port") != 0) > + continue; > + of_property_read_u32(port, "reg", &port_id); > + if (id == port_id) > + return port; > + } > + > + return NULL; > +} > +EXPORT_SYMBOL(of_graph_get_port_by_id); > + > +/** > * of_graph_get_next_endpoint() - get next endpoint node > * @parent: pointer to the parent device node > * @prev: previous endpoint node, or NULL to get first > diff --git a/include/linux/of_graph.h b/include/linux/of_graph.h > index e43442e..3c1c95a 100644 > --- a/include/linux/of_graph.h > +++ b/include/linux/of_graph.h > @@ -40,6 +40,7 @@ struct of_endpoint { > #ifdef CONFIG_OF > int of_graph_parse_endpoint(const struct device_node *node, > struct of_endpoint *endpoint); > +struct device_node *of_graph_get_port_by_id(struct device_node *node, u32 > id); struct device_node *of_graph_get_next_endpoint(const struct > device_node *parent, struct device_node *previous); > struct device_node *of_graph_get_remote_port_parent( > @@ -53,6 +54,12 @@ static inline int of_graph_parse_endpoint(const struct > device_node *node, return -ENOSYS; > } > > +static inline struct device_node *of_graph_get_port_by_id( > + struct device_node *node, u32 id) > +{ > + return NULL; > +} > + > static inline struct device_node *of_graph_get_next_endpoint( > const struct device_node *parent, > struct device_node *previous) -- Regards, Laurent Pinchart