Re: Suspend/Resume

Jens Axboe
2005-05-08T16:21:47Z

On May 8, 2005, at 5:53 AM, James Bottomley wrote:

> On Tue, 2005-05-03 at 16:10 +0200, Jens Axboe wrote:
>
>> I don't know, depends on what Jeff/James think of this approach.
>> There
>> are many different way to solve this problem. I let the scsi bus
>> called
>> suspend/resume for the devices on that bus, and let the scsi host
>> adapter perform any device dependent actions. The pci helpers are
>> less
>> debatable.
>>
>> Jeff/James? Here's a patch that applies to current git.
>>
>
> The patch looks fine as far as it goes ... however, shouldn't we be
> spinning *internal* suspended drives down as well like IDE does
> (i.e. at
> least the sd ULD needs to be a party to the suspend)? Of course
> this is
> a complete can of worms since we really have no idea which busses are
> internal and which are external, although it might be something that
> userland can determine.

I'm not sure I know what you mean by 'internal suspended drives' that
aren't spun down? For every device known on the sata "bus", we do the
standby routine.

There is room for improvement for software suspend, notably it is
extremely annoying that we cannot tell the difference between
'freeze' and 'suspend' currently, this adds overhead for suspend-to-
disk both in time spent and actual drive wear due to an excessive
spin down+up cycle.

> P.S. I noticed the gratuitous coding style corrections ...

Heh woops, I usually don't sneak those in with other changes. I think
this one got in because I actually had another change there that I
later reverted.

Jens