From: Stefan Seyfried <seife@suse.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: LKML <linux-kernel@vger.kernel.org>, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH] swsusp: misc cleanups [4/4]
Date: Sun, 24 Apr 2005 12:57:27 +0200 [thread overview]
Message-ID: <426B7B97.4030009@suse.de> (raw)
In-Reply-To: <20050423220757.GD1884@elf.ucw.cz>
Pavel Machek wrote:
> Hi!
>
>> The following patch makes some comments and printk()s in swsusp.c up to date.
>> In particular it adds the string "swsusp" before every message that is printed by
>> the code in swsusp.c.
>
> I don't like this one. Adding swsusp everywhere just clutters the
> screen, most of it should be clear from context.
I like it. The messages are short enough so we should not get line wraps
and it makes stuff more clear. You know, the context is not familiar to
everyone, just imagine the "why do we {suspend,resume} devices during
{resume,suspend} questions.
Also, i can ask for "send me output of dmesg|grep ^swsusp" to avoid
newbies flooding me with totally irrelevant info ;-)
--
Stefan Seyfried, QA / R&D Team Mobile Devices, SUSE LINUX Nürnberg.
"Any ideas, John?"
"Well, surrounding them's out."
next prev parent reply other threads:[~2005-04-24 10:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-23 21:20 [PATCH] swsusp: misc cleanups [0/4] Rafael J. Wysocki
2005-04-23 21:25 ` [PATCH] swsusp: misc cleanups [1/4] Rafael J. Wysocki
2005-04-23 22:05 ` Pavel Machek
2005-04-23 21:29 ` [PATCH] swsusp: misc cleanups [2/4] Rafael J. Wysocki
2005-04-23 22:02 ` Pavel Machek
2005-04-23 21:34 ` [PATCH] swsusp: misc cleanups [3/4] Rafael J. Wysocki
2005-04-23 22:18 ` Pavel Machek
2005-04-24 10:41 ` Rafael J. Wysocki
2005-04-24 20:23 ` Pavel Machek
2005-04-23 21:38 ` [PATCH] swsusp: misc cleanups [4/4] Rafael J. Wysocki
2005-04-23 22:07 ` Pavel Machek
2005-04-24 10:30 ` Rafael J. Wysocki
2005-04-24 20:20 ` Pavel Machek
2005-04-24 10:57 ` Stefan Seyfried [this message]
2005-04-24 20:22 ` Pavel Machek
2005-04-24 20:43 ` Stefan Seyfried
2005-04-24 21:03 ` Pavel Machek
2005-04-23 21:58 ` [PATCH] swsusp: misc cleanups [0/4] Pavel Machek
2005-04-24 10:06 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=426B7B97.4030009@suse.de \
--to=seife@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox