Re: [patch] fix the 2nd buffer race properly

Nick Piggin
2005-04-27T13:20:54Z

Nick Piggin wrote:

> The bug (the reason I asked you to drop the patch just now)
> was that the code previously did a get_bh on all bh's in a
> page, but I changed it to only put_bh the ones to be written.
>
> The minor fix for that was to only get_bh the buffer heads to
> be written.
>

Err, that wasn't very clear: my earlier patch to fix the problem
introduced the above bh leak, but was otherwise correct in that
it solved the underlying problem.