From: Nick Piggin <nickpiggin@yahoo.com.au>
To: dino@in.ibm.com
Cc: Paul Jackson <pj@sgi.com>, Simon Derr <Simon.Derr@bull.net>,
lkml <linux-kernel@vger.kernel.org>,
lse-tech <lse-tech@lists.sourceforge.net>,
Matthew Dobson <colpatch@us.ibm.com>,
Dipankar Sarma <dipankar@in.ibm.com>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [RFC PATCH] Dynamic sched domains (v0.5)
Date: Mon, 02 May 2005 19:44:05 +1000 [thread overview]
Message-ID: <4275F665.1010101@yahoo.com.au> (raw)
In-Reply-To: <20050501190947.GA5204@in.ibm.com>
Dinakar Guniguntala wrote:
> +void rebuild_sched_domains(cpumask_t span1, cpumask_t span2)
> +{
> + cpumask_t change_map;
> +
> + cpus_or(change_map, span1, span2);
> +
> + preempt_disable();
Oh, you can't do this here, attach_domains does a synchronize_kernel.
So take it out, it doesn't do anything anyway, does it?
I suggest you also use some sort of locking to prevent concurrent rebuilds
and rebuilds racing with cpu hotplug. You could probably have a static
semaphore around rebuild_sched_domains, and take lock_cpu_hotplug here too.
Or alternatively take the semaphore in the cpu hotplug notifier as well...
Maybe both - neither are performance critical code.
--
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2005-05-02 9:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-01 19:09 [RFC PATCH] Dynamic sched domains (v0.5) Dinakar Guniguntala
2005-05-02 9:10 ` Nick Piggin
2005-05-02 17:17 ` Dinakar Guniguntala
2005-05-02 9:44 ` Nick Piggin [this message]
2005-05-02 17:16 ` Dinakar Guniguntala
2005-05-02 23:23 ` Nick Piggin
2005-05-03 14:58 ` Dinakar Guniguntala
2005-05-03 15:31 ` Paul Jackson
2005-05-02 18:01 ` Paul Jackson
2005-05-03 14:44 ` Dinakar Guniguntala
2005-05-03 15:21 ` Paul Jackson
2005-05-03 15:24 ` Paul Jackson
2005-05-03 22:03 ` Matthew Dobson
2005-05-04 0:08 ` Nick Piggin
2005-05-04 0:28 ` Matthew Dobson
2005-05-05 13:28 ` Dinakar Guniguntala
2005-05-05 13:26 ` Dinakar Guniguntala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4275F665.1010101@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=Simon.Derr@bull.net \
--cc=akpm@osdl.org \
--cc=colpatch@us.ibm.com \
--cc=dino@in.ibm.com \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@lists.sourceforge.net \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox