* [PATCH] crypto: public_key: select CRYPTO_AKCIPHER2
@ 2016-05-18 14:12 Arnd Bergmann
2016-05-18 14:50 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2016-05-18 14:12 UTC (permalink / raw)
To: David Howells, Herbert Xu, David S. Miller
Cc: Arnd Bergmann, Tadeusz Struk, keyrings, linux-crypto,
linux-kernel
In some rare randconfig builds, we can end up with
ASYMMETRIC_PUBLIC_KEY_SUBTYPE enabled but CRYPTO_AKCIPHER2 disabled,
which fails to link because of the reference to crypto_alloc_akcipher:
crypto/built-in.o: In function `public_key_verify_signature':
:(.text+0x110e4): undefined reference to `crypto_alloc_akcipher'
This adds a Kconfig 'select' statement to ensure the dependency
is always there.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
crypto/asymmetric_keys/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
index e28e912000a7..c93723a852d9 100644
--- a/crypto/asymmetric_keys/Kconfig
+++ b/crypto/asymmetric_keys/Kconfig
@@ -13,6 +13,7 @@ config ASYMMETRIC_PUBLIC_KEY_SUBTYPE
tristate "Asymmetric public-key crypto algorithm subtype"
select MPILIB
select CRYPTO_HASH_INFO
+ select CRYPTO_AKCIPHER2
help
This option provides support for asymmetric public key type handling.
If signature generation and/or verification are to be used,
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: public_key: select CRYPTO_AKCIPHER2
2016-05-18 14:12 [PATCH] crypto: public_key: select CRYPTO_AKCIPHER2 Arnd Bergmann
@ 2016-05-18 14:50 ` Herbert Xu
2016-05-18 14:56 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Herbert Xu @ 2016-05-18 14:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David Howells, David S. Miller, Tadeusz Struk, keyrings,
linux-crypto, linux-kernel
On Wed, May 18, 2016 at 04:12:44PM +0200, Arnd Bergmann wrote:
> In some rare randconfig builds, we can end up with
> ASYMMETRIC_PUBLIC_KEY_SUBTYPE enabled but CRYPTO_AKCIPHER2 disabled,
> which fails to link because of the reference to crypto_alloc_akcipher:
This symbol is not meant to be selected by crypto users. Please
select CRYPTO_AKCIPHER instead.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: public_key: select CRYPTO_AKCIPHER2
2016-05-18 14:50 ` Herbert Xu
@ 2016-05-18 14:56 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-05-18 14:56 UTC (permalink / raw)
To: Herbert Xu
Cc: David Howells, David S. Miller, Tadeusz Struk, keyrings,
linux-crypto, linux-kernel
On Wednesday 18 May 2016 22:50:31 Herbert Xu wrote:
> On Wed, May 18, 2016 at 04:12:44PM +0200, Arnd Bergmann wrote:
> > In some rare randconfig builds, we can end up with
> > ASYMMETRIC_PUBLIC_KEY_SUBTYPE enabled but CRYPTO_AKCIPHER2 disabled,
> > which fails to link because of the reference to crypto_alloc_akcipher:
>
> This symbol is not meant to be selected by crypto users. Please
> select CRYPTO_AKCIPHER instead.
>
Ok, sent a v2 now.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-18 14:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-18 14:12 [PATCH] crypto: public_key: select CRYPTO_AKCIPHER2 Arnd Bergmann
2016-05-18 14:50 ` Herbert Xu
2016-05-18 14:56 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox