Re: [2.6 patch] {,un}register_ioctl32_conversion should have been removed last month

Thomas Winischhofer
2005-05-03T07:31:10Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Adrian Bunk wrote:
> On Mon, May 02, 2005 at 05:30:52PM -0700, Andrew Morton wrote:
>
>>Adrian Bunk <bunk@stusta.de> wrote:
>>
>>>This removal should have happened last month.
>>
>>drivers/usb/misc/sisusbvga/sisusb.c will use these functions if someone
>>defines SISUSB_OLD_CONFIG_COMPAT, so we need to agree to zap that code
>>before I can merge this upstream.

Why on earth should anyone #define something with "SISUSB" in the
beginning, on a level that might be available in a usb driver?

>
> That's not a problem.
>
>
> Quoting drivers/usb/misc/sisusbvga/sisusb.h:
>
> #ifdef CONFIG_COMPAT
> #if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,10)
> #include <linux/ioctl32.h>
> #define SISUSB_OLD_CONFIG_COMPAT
> #else
> #define SISUSB_NEW_CONFIG_COMPAT
> #endif
> #endif
>
>
> I decided not to drop the SISUSB_OLD_CONFIG_COMPAT code in my patch
> because it seems Thomas is sharing this code between different kernel
> versions, and a removal might make his life harder for no big win.

Exactly. Thanks, Adrian.

Thomas

- --
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net *** http://www.winischhofer.net
twini AT xfree86 DOT org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCdyh+zydIRAktyUcRAgTLAKDJ7woebRDkqRS70aImI5c0y+fiyQCgyNqE
8haWeqvcbbbCjYn607Xh51E=
=ZaoZ
-----END PGP SIGNATURE-----