Re: [RFC PATCH] Dynamic sched domains (v0.5)

Matthew Dobson
2005-05-04T00:28:30Z

Nick Piggin wrote:
> Matthew Dobson wrote:
>
>> Dinakar Guniguntala wrote:
>>
>>> + lock_cpu_hotplug();
>>> + rebuild_sched_domains(span1, span2);
>>> + unlock_cpu_hotplug();
>>> +}
>>
>>
>>
>> Nitpicky, but span1 and span2 could do with better names.
>>
>
> As could rebuild_sched_domains while we're at it.
>
> partition_disjoint_sched_domains(partition1, partition2);
> ?
>
> Dunno. That isn't really great, but maybe better? Pretty
> long, but it'll only ever be called in one or two places.

build_disjoint_sched_domains(partition1, partition2)? Or just
partition_sched_domains(partition1, partition2)? Partition and disjoint
seem mildly redundant to me, for varying definitions of partition... ;)

-Matt