Re: [PATCH 2/3] add open iscsi netlink interface to iscsi transport class

YOSHIFUJI Hideaki / 吉藤英明
2005-05-05T11:52:55Z

In article <E1DTehn-0005gJ-00@gondolin.me.apana.org.au> (at Thu, 05 May 2005 21:39:47 +1000), Herbert Xu <herbert@gondor.apana.org.au> says:

> YOSHIFUJI Hideaki / ???? <yoshfuji@linux-ipv6.org> wrote:
> > In article <42798AC1.2010308@cs.wisc.edu> (at Wed, 04 May 2005 19:53:53 -0700), Mike Christie <michaelc@cs.wisc.edu> says:
> >
> >> +struct iscsi_uevent {
> > :
> >> +} __attribute__ ((aligned (sizeof(unsigned long))));
> >
> > I think it'd be better to use sizeof(uint64_t) or something.
>
> Is there a benefit in aligning on 64-bit boundaries for 32-bit platforms?

Well, this if for avoiding inconsistency between kernel and userspace.
If you use unsigned long, sizeof(unsigned long) may be inconssitent
between kernel and userland like this:
kernel: sizeof(unsigned long) == 8
userspace: sizeof(unsigned long) == 4

--yoshfuji