Re: [RFC][PATCH] timers fixes/improvements

[Oleg Nesterov <oleg@tv-sign.ru>]

Christoph Lameter wrote:
> 
> On Mon, 9 May 2005, Andrew Morton wrote:
> 
> > ptype_base is an array, but I cannot see any race around ptype_base.  So
> > look to see if ptype_base is corrupted as well, keep walking back through
> > memory, see where the scribble starts.
> 
> There is no corruption around ptype_all as you can see from the log. There
> is a list of hex numbers which are from ptype_all -8 to ptype_all +8.
> Looks okay to me.

Still ptype_all could be accessed (and corrupted) as ptype_base[16].

Christoph, could you please reboot with this patch?
Just to be sure.

--- 2.6.12-rc4/net/core/dev.c~	Tue May 10 12:24:11 2005
+++ 2.6.12-rc4/net/core/dev.c	Tue May 10 14:19:29 2005
@@ -157,7 +157,9 @@
 
 static DEFINE_SPINLOCK(ptype_lock);
 static struct list_head ptype_base[16];	/* 16 way hashed list */
+static unsigned long ptype_before[4] = { [0 ... 3] = -1 };
 static struct list_head ptype_all;		/* Taps */
+static unsigned long ptype_after[4] = { [0 ... 3] = -1 };
 
 #ifdef OFFLINE_SAMPLE
 static void sample_queue(unsigned long dummy);