public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paulo Marques <pmarques@grupopie.com>
To: Imre Deak <imre.deak@nokia.com>
Cc: linux-kernel@vger.kernel.org, kaos@ocs.com.au,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: arm: Inconsistent kallsyms data
Date: Wed, 11 May 2005 11:59:58 +0100	[thread overview]
Message-ID: <4281E5AE.4090601@grupopie.com> (raw)
In-Reply-To: <1115802310.9757.20.camel@mammoth.research.nokia.com>

Imre Deak wrote:
> Hi,
> 
> building 2.6.12-rc4 results in "Inconsistent kallsyms data". Setting
> CONFIG_KALLSYMS_EXTRA_PASS=y doesn't help.
> 
> I made a diff of .tmp_kallsyms[12].S after converting them to human
> readable form with kallsyms_uncompress.pl .

 From the diff, I can see the problem is that "__bss_start" changes 
position with "_edata" from the first to the second pass.

If your read my post from yesterday "Re: Linux v2.6.12-rc4" (not a very 
descriptive subject), I explain there why this is a problem.

Sam, from looking at your patch, it seems that the patch shouldn't 
affect these particular symbols. Am I correct?

Maybe we really need the more robust fix to kallsyms, so that this sort 
of thing doesn't bite us in the future, no matter what symbols change 
position.

> I noticed that the error is triggered by an __initdata definition. It is
> accessed only from an __init function, so that's ok I think. Removing
> the __initdata attribute gets rid of the error message.

This is just a "tape over" solution that makes the symbols change 
positions, so that maybe these 2 symbols don't get selected for sampling.

> Let me know if you need more data to track the problem.

There is a simple workaround that is to increase the WORKING_SET define 
in scripts/kallsyms.c to something like 65536. This will include every 
symbol in the token table calculation, so that even if symbol position 
changes, the token table should be the same.

I tested this with a configuration I have here that had a similar 
problem and it indeed worked as expected.

The problem with this approach is that it takes longer to calculate the 
token table. (~3secs on my P4 2.8GHz, 11300 symbols)

-- 
Paulo Marques - www.grupopie.com

An expert is a person who has made all the mistakes that can be
made in a very narrow field.
Niels Bohr (1885 - 1962)

  parent reply	other threads:[~2005-05-11 11:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-11  9:05 arm: Inconsistent kallsyms data Imre Deak
2005-05-11 10:57 ` Keith Owens
2005-05-11 21:15   ` Sam Ravnborg
2005-05-11 10:59 ` Paulo Marques [this message]
2005-05-11 21:21   ` Sam Ravnborg
2005-05-11 21:47 ` Russell King
2005-05-11 23:53   ` Imre Deak
2005-05-12  5:20 ` Keith Owens
  -- strict thread matches above, loose matches on Subject: below --
2005-05-12  9:40 Imre.Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4281E5AE.4090601@grupopie.com \
    --to=pmarques@grupopie.com \
    --cc=imre.deak@nokia.com \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox