public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kirill Korotaev <dev@sw.ru>
To: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
	linux-kernel@vger.kernel.org, pavel@suse.cz, pavel@ucw.cz
Subject: [PATCH] Software suspend and recalc sigpending bug fix
Date: Wed, 11 May 2005 19:20:47 +0400	[thread overview]
Message-ID: <428222CF.3070002@sw.ru> (raw)

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

This patch fixes recalc_sigpending() to work correctly
with tasks which are being freezed. The problem is that
freeze_processes() sets PF_FREEZE and TIF_SIGPENDING
flags on tasks, but recalc_sigpending() called from
e.g. sys_rt_sigtimedwait or any other kernel place
will clear TIF_SIGPENDING due to no pending signals queued
and the tasks won't be freezed until it recieves a real signal
or freezed_processes() fail due to timeout.

Signed-Off-By: Kirill Korotaev <dev@sw.ru>
Signed-Off-By: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>

[-- Attachment #2: diff-mainstream-freezesigrecalc-20050429 --]
[-- Type: text/plain, Size: 466 bytes --]

--- ./kernel/signal.c.freezesigrec	2005-05-10 16:10:40.000000000 +0400
+++ ./kernel/signal.c	2005-05-10 18:10:08.000000000 +0400
@@ -212,6 +212,7 @@ static inline int has_pending_signals(si
 fastcall void recalc_sigpending_tsk(struct task_struct *t)
 {
 	if (t->signal->group_stop_count > 0 ||
+	    (t->flags&PF_FREEZE) ||
 	    PENDING(&t->pending, &t->blocked) ||
 	    PENDING(&t->signal->shared_pending, &t->blocked))
 		set_tsk_thread_flag(t, TIF_SIGPENDING);

             reply	other threads:[~2005-05-11 15:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-11 15:20 Kirill Korotaev [this message]
2005-05-11 18:04 ` [PATCH] Software suspend and recalc sigpending bug fix Pavel Machek
2005-05-12  6:43   ` Kirill Korotaev
2005-05-12  8:55     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=428222CF.3070002@sw.ru \
    --to=dev@sw.ru \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    --cc=pavel@ucw.cz \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox