From: Carsten Otte <cotte@freenet.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
schwidefsky@de.ibm.com, akpm@osdl.org
Subject: Re: [RFC/PATCH 2/5] mm/fs: add execute in place support
Date: Wed, 11 May 2005 17:33:59 +0200 [thread overview]
Message-ID: <428225E7.4070605@freenet.de> (raw)
In-Reply-To: <20050511150924.GA29976@infradead.org>
Christoph Hellwig wrote:
> This is a lot of code for a very special case.
>
>Could you try to put all the xip code into a separate file, e.g. mm/xip.c
>that's only built when CONFIG_XIP is set? It would probably require
>duplicating a little more code if you want clean interfaces, e.g. probably
>a separate set of generic operations.
>
>
>
Indeed that seems reasonable. There is no exact reason to have
this built into a kernel on a platform that does not have a bdev
for this. On the other hand, I believe the code should stay in
filemap.c, because it fits there conceptually. And I personally
dislike #ifdef in the middle of a file.
next prev parent reply other threads:[~2005-05-11 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-11 14:30 [RFC/PATCH 2/5] mm/fs: add execute in place support Carsten Otte
2005-05-11 15:09 ` Christoph Hellwig
2005-05-11 15:33 ` Carsten Otte [this message]
2005-05-11 15:47 ` Badari Pulavarty
2005-05-11 16:19 ` Carsten Otte
2005-05-11 17:31 ` Arnd Bergmann
2005-05-11 17:47 ` Carsten Otte
2005-05-11 17:50 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428225E7.4070605@freenet.de \
--to=cotte@freenet.de \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox