From: Corey Minyard <minyard@acm.org>
To: lkml <linux-kernel@vger.kernel.org>
Subject: acpi=off and acpi_get_firmware_table
Date: Wed, 11 May 2005 12:21:25 -0500 [thread overview]
Message-ID: <42823F15.7090601@acm.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
In 2.6.12-rc4, I added acpi=off to the kernel command line and it
panic-ed in acpi_get_firmware_table, called from the IPMI driver.
The attached patch fixes the problem, but it still spits out ugly
"ACPI-0166: *** Error: Invalid address flags 8" errors. So I doubt the
patch is right, but maybe it points to something else.
Is it legal to call acpi_get_firmware_table if acpi is off? If not, how
can I tell that acpi is off?
-Corey
[-- Attachment #2: acpi_table_null_fix.patch --]
[-- Type: text/x-patch, Size: 528 bytes --]
Index: linux-2.6.12-rc4/drivers/acpi/tables/tbxfroot.c
===================================================================
--- linux-2.6.12-rc4.orig/drivers/acpi/tables/tbxfroot.c
+++ linux-2.6.12-rc4/drivers/acpi/tables/tbxfroot.c
@@ -313,7 +313,9 @@
cleanup:
- acpi_os_unmap_memory (rsdt_info->pointer, (acpi_size) rsdt_info->pointer->length);
+ if (rsdt_info->pointer)
+ acpi_os_unmap_memory (rsdt_info->pointer,
+ (acpi_size) rsdt_info->pointer->length);
ACPI_MEM_FREE (rsdt_info);
if (header) {
next reply other threads:[~2005-05-11 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-11 17:21 Corey Minyard [this message]
2005-05-12 2:54 ` acpi=off and acpi_get_firmware_table Shaohua Li
2005-05-12 2:59 ` Corey Minyard
2005-05-12 3:07 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42823F15.7090601@acm.org \
--to=minyard@acm.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox