Re: [rfc/patch] libata -- port configurable delays

Benjamin LaHaise
2005-05-13T20:01:51Z

On Fri, May 13, 2005 at 03:13:50PM -0400, Jeff Garzik wrote:
> This delay is based on field experience, rather than spec. I'm open to
> making this optional, as you have done. Some issues related to this
> delay, to consider:

Do you have the original bug reports so we know which chipsets / drive
combinations are problematic?

> 1) Nothing in life is free. This delay is useful on some platforms,
> because banging away at the Status register for extended periods of time
> can cause an insane amount of PCI IO traffic. Removing the delay just
> moves the punishment from one area to another.

In this case the time to complete the task is reduced by 18%, so the
delay is definately excessive. That 18% is remarkably close to the
19.5% hit for __delay in the profile results.

> 2) In a few controllers, the SATA<->FIS emulation can go kerflooey if
> you bang the Status register 'too hard'.

The patch only enables it on one variant of ICH6 SATA so far.

> 3) IIRC some rare PATA devices don't like having their Status register
> banged "too hard". No data, just a vague memory.
>
> 4) It may be worthwhile to rewrite the loop to check the Status register
> _first_, then delay.
>
> Finally, simply disabling the delay is IMO _far_ too dangerous on such a
> popular driver (ata_piix).

Have you a better suggestion for blacklisting devices?

> I would be conservative, and create a module option for libata (not
> ata_piix) which allows a user to globally disable the delay. And make
> sure that option defaults to 'delay', the current behavior.

This option is undesirable for hardware which behaves correctly. The
vast majority of users aren't going to be fiddling with hdparm options
(I certainly don't want to see modern SATA being a repeat of the magic
handwaving the IDE driver and DMA went through for years).

At the very least the option should be introduced and new drivers should
start life without these legacy delays in place. If doing it on a per
port interface isn't good enough, what is? Globally seems worse to me
as then any system with a mix of old and new hardware isn't going to do
the right thing.

-ben
--
"Time is what keeps everything from happening all at once." -- John Wheeler