* [patch 2/3] drivers/char/hw_random.c: replace direct assignment with set_current_state()
@ 2005-05-13 22:24 domen
2005-05-14 0:22 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: domen @ 2005-05-13 22:24 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, Christophe Lucas, domen
[-- Attachment #1: set_current_state-drivers_char_hw_random --]
[-- Type: text/plain, Size: 701 bytes --]
From: Christophe Lucas <clucas@rotomalug.org>
Use set_current_state() instead of direct assignment of
current->state.
Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
hw_random.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: quilt/drivers/char/hw_random.c
===================================================================
--- quilt.orig/drivers/char/hw_random.c
+++ quilt/drivers/char/hw_random.c
@@ -514,7 +514,7 @@ static ssize_t rng_dev_read (struct file
if(need_resched())
{
- current->state = TASK_INTERRUPTIBLE;
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(1);
}
else
--
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 2/3] drivers/char/hw_random.c: replace direct assignment with set_current_state()
2005-05-13 22:24 [patch 2/3] drivers/char/hw_random.c: replace direct assignment with set_current_state() domen
@ 2005-05-14 0:22 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2005-05-14 0:22 UTC (permalink / raw)
To: domen; +Cc: akpm, linux-kernel, Christophe Lucas
domen@coderock.org wrote:
> From: Christophe Lucas <clucas@rotomalug.org>
>
>
>
> Use set_current_state() instead of direct assignment of
> current->state.
>
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
> Signed-off-by: Domen Puncer <domen@coderock.org>
>
>
> ---
> hw_random.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: quilt/drivers/char/hw_random.c
> ===================================================================
> --- quilt.orig/drivers/char/hw_random.c
> +++ quilt/drivers/char/hw_random.c
> @@ -514,7 +514,7 @@ static ssize_t rng_dev_read (struct file
>
> if(need_resched())
> {
> - current->state = TASK_INTERRUPTIBLE;
> + set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(1);
full barriers and such don't seem needed.
Also, make sure to send driver patches to the driver author (me).
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-05-14 0:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-13 22:24 [patch 2/3] drivers/char/hw_random.c: replace direct assignment with set_current_state() domen
2005-05-14 0:22 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox