Re: [patch 2/3] drivers/char/hw_random.c: replace direct assignment with set_current_state()

Jeff Garzik
2005-05-14T00:34:58Z

domen@coderock.org wrote:
> From: Christophe Lucas <clucas@rotomalug.org>
>
>
>
> Use set_current_state() instead of direct assignment of
> current->state.
>
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
> Signed-off-by: Domen Puncer <domen@coderock.org>
>
>
> ---
> hw_random.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: quilt/drivers/char/hw_random.c
> ===================================================================
> --- quilt.orig/drivers/char/hw_random.c
> +++ quilt/drivers/char/hw_random.c
> @@ -514,7 +514,7 @@ static ssize_t rng_dev_read (struct file
>
> if(need_resched())
> {
> - current->state = TASK_INTERRUPTIBLE;
> + set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(1);

full barriers and such don't seem needed.

Also, make sure to send driver patches to the driver author (me).

Jeff