Re: 2.6.12-rc4-mm2

[Brice Goglin <Brice.Goglin@ens-lyon.org>]

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

Andrew Morton a écrit :
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc4/2.6.12-rc4-mm2/
> 
> 
> - davem has set up a mm-commits mailing list so people can review things
>   which are added to or removed from the -mm tree.  Do
> 
> 	echo subscribe mm-commits | mail majordomo@vger.kernel.org
> 
> - x86_64 architecture update from Andi.
> 
> - Everything up to and including `spurious-interrupt-fix.patch' is planned
>   for 2.6.12 merging.  Plus a few other things in there.
> 
> - Another DVB subsystem update

Hi Andrew,

CONFIG_PPP_MPPE can be enabled without CONFIG_CRYPTO.
This results in this warning when running make modules_install:
if [ -r System.map -a -x /sbin/depmod ]; then /sbin/depmod -ae -F
System.map  2.6.12-rc4-mm2=LoulousMobile; fi
WARNING:
/lib/modules/2.6.12-rc4-mm2=LoulousMobile/kernel/drivers/net/ppp_mppe.ko
needs unknown symbol crypto_alloc_tfm
WARNING:
/lib/modules/2.6.12-rc4-mm2=LoulousMobile/kernel/drivers/net/ppp_mppe.ko
needs unknown symbol crypto_free_tfm

By the way, looking at drivers/net/ppp_mppe.c, it looks like sha1 and
arc4 are needed at runtime.

The attached patch selects all these when PPP_MPPE is selected.

Signed-off-by: Brice Goglin <Brice.Goglin@ens-lyon.org>

Brice

[-- Attachment #2: fix_ppp-mppe_dependencies.patch --]
[-- Type: text/x-patch, Size: 521 bytes --]

--- linux-mm/drivers/net/Kconfig.old	2005-05-16 14:15:29.000000000 +0200
+++ linux-mm/drivers/net/Kconfig	2005-05-16 14:24:44.000000000 +0200
@@ -2431,6 +2431,9 @@ config PPP_BSDCOMP
 config PPP_MPPE
        tristate "PPP MPPE compression (encryption) (EXPERIMENTAL)"
        depends on PPP && EXPERIMENTAL
+       select CRYPTO
+       select CRYPTO_SHA1
+       select CRYPTO_ARC4
        ---help---
          Support for the MPPE Encryption protocol, as employed by the
 	 Microsoft Point-to-Point Tunneling Protocol.