From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751237AbdCQRak (ORCPT ); Fri, 17 Mar 2017 13:30:40 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:52133 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751222AbdCQRaf (ORCPT ); Fri, 17 Mar 2017 13:30:35 -0400 X-AuditID: b6c32a35-f79d66d000001a37-22-58cc1cbf06f8 From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Vladimir Zapolskiy , Nathan Royce Subject: Re: [PATCH 4/4] crypto: s5p-sss - Use mutex instead of spinlock Date: Fri, 17 Mar 2017 18:28:29 +0100 Message-id: <4289522.7Nbtc4pSSm@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170317144922.27379-5-krzk@kernel.org> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKKsWRmVeSWpSXmKPExsWy7bCmge5+mTMRBj9ea1rMOd/CYtH9Ssbi /PkN7Bb37/1ksri8aw6bxaJl11kt/v9qZnZg99iy8iaTx85Zd9k9th1Q9di0qpPN49/CKSwe nzfJBbBFcdmkpOZklqUW6dslcGWceTGPuWA6Z8XfdXuZGhh3sncxcnJICJhIPDv8jwXCFpO4 cG89WxcjF4eQwA5GiVW/nrKCJIQE2pkkGs/ANZxe0QsVX84osfhtDYT9lVHi/wINEJtNwEpi YvsqRhBbREBT4vrf76wgQ5kFHjNKnPn9GGyQsICHxJtZH8CKWARUJd6dbWEGsXmBGvY8fs8E YosKeEls2dcOZnMKmEp0LzzJCFEjKPFj8j2wq5kF5CX27Z/KCmHrSJw9to4RZJmEwDp2id7f T4GKOIAcWYlNB5ghHnCR2LnzPyOELSzx6vgWqMekJVb9u8UEYU9nlNj+WwJizmZgSOyeAFVk LXH4+EWoZXwS7772sELM55XoaBOCKPGQmHL9LjREHSX+XrjBAglRoDnrrv9im8AoPwvJD7OQ /DALyQ8LGJlXMYqlFhTnpqcWGxYY6hUn5haX5qXrJefnbmIEJxYt0x2MU875HGIU4GBU4uG9 8eR0hBBrYllxZe4hRgkOZiUR3t2CZyKEeFMSK6tSi/Lji0pzUosPMUpzsCiJ87IaTIwQEkhP LEnNTk0tSC2CyTJxcEo1MEZc2Tt1jl/2cTcllSm7Y9Ltb7ueMp5vsnHW91olk4lyr2RKEv8/ unF0WiGb3qfzjZP3Td0bWV3SuuTQlN9tk/f+iJOMXOoo/YTX6YFedWMBw/QHE2Sc+YP7r0op ie3zLHyzMLl+1xKp3NevTBxn8ift+pNw9Ffx9jUbb0wQ5Gteud2wVD1+aZESS3FGoqEWc1Fx IgDlJe8WKAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRmVeSWpSXmKPExsVy+t9jAd39MmciDJr/CFrMOd/CYtH9Ssbi /PkN7Bb37/1ksri8aw6bxaJl11kt/v9qZnZg99iy8iaTx85Zd9k9th1Q9di0qpPN49/CKSwe nzfJBbBFudlkpCampBYppOYl56dk5qXbKoWGuOlaKCnkJeam2ipF6PqGBCkplCXmlAJ5RgZo wME5wD1YSd8uwS3jzIt5zAXTOSv+rtvL1MC4k72LkZNDQsBE4vSKXlYIW0ziwr31bF2MXBxC AksZJfaeu88M4XxllPiyrY8RpIpNwEpiYvsqMFtEQFPi+t/vrCBFzAKPGSU+nfsCNlZYwEPi zawPYEUsAqoS7862MIPYvEANex6/ZwKxRQW8JLbsawezOQVMJboXngSrFxKIlzjfuoQFol5Q 4sfke2A2s4C8xL79U1khbC2J9TuPM01gFJiFpGwWkrJZSMoWMDKvYpRILUguKE5KzzXMSy3X K07MLS7NS9dLzs/dxAiOtmdSOxgP7nI/xCjAwajEw3vjyekIIdbEsuLK3EOMEhzMSiK8uwXP RAjxpiRWVqUW5ccXleakFh9iNAV6cCKzlGhyPjAR5JXEG5qYm5gbG1iYW1qaGCmJ8zbOfhYu JJCeWJKanZpakFoE08fEwSnVwMiy5tsOvjMhQYxcc/fMeZC69MB9kYcrCxISy0X2vtiy9qVa nGy75KwCsTl8/J9Paf548r2wMMPn/MW1hWxn8q/5Vr9/Ja1nsWPi2xyWXuPzYvs4dzLfjl21 uOvbpaNKumsCN/56KK2VyX4iqJbDIPzz3QzW4v1rUnxkVxhOj+ryyfITfK26/qISS3FGoqEW c1FxIgBE0D32zAIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170317172831epcas1p12280386c43fd0b819bb87cf4ba78eab3 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170317172831epcas1p12280386c43fd0b819bb87cf4ba78eab3 X-RootMTR: 20170317172831epcas1p12280386c43fd0b819bb87cf4ba78eab3 References: <20170317144922.27379-1-krzk@kernel.org> <20170317144922.27379-5-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Friday, March 17, 2017 04:49:22 PM Krzysztof Kozlowski wrote: > Driver uses threaded interrupt handler so there is no real need for > using spinlocks for synchronization. Mutexes would do fine and are > friendlier for overall system preemptivness and real-time behavior. Are you sure that this conversion is safe? This driver also uses a tasklet and tasklets run in the interrupt context. > @@ -667,18 +666,17 @@ static void s5p_tasklet_cb(unsigned long data) > struct s5p_aes_dev *dev = (struct s5p_aes_dev *)data; > struct crypto_async_request *async_req, *backlog; > struct s5p_aes_reqctx *reqctx; > - unsigned long flags; > > - spin_lock_irqsave(&dev->lock, flags); > + mutex_lock(&dev->lock); > backlog = crypto_get_backlog(&dev->queue); > async_req = crypto_dequeue_request(&dev->queue); > > if (!async_req) { > dev->busy = false; > - spin_unlock_irqrestore(&dev->lock, flags); > + mutex_unlock(&dev->lock); > return; > } > - spin_unlock_irqrestore(&dev->lock, flags); > + mutex_unlock(&dev->lock); Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics