Re: [RFC/PATCH 1/5] bdev: execute in place (V2)

Christoph Hellwig
2005-05-18T15:44:32Z

On Wed, May 18, 2005 at 05:36:49PM +0200, Carsten Otte wrote:
> Christoph Hellwig wrote:
>
> >>+ int (*direct_access) (struct inode *, sector_t, unsigned long *);
> >>
> >>
> >
> >this should have a block_device * first argument.
> >
> >
> While I agree that (block_device *) would be a good thing to address
> the target block device, the inode * is consistent with other
> operations in this vector: open, release, & ioctl use the same scheme.

That's going to change real soon.

> The reason for inode * here is that the caller has no easy way to get
> to the block_device *. How would the filesystem do that?

sb->s_bdev