Re: [RFC/PATCH 4/5] loop: execute in place (V2)

Christoph Hellwig
2005-05-18T14:45:50Z

On Wed, May 18, 2005 at 03:53:52PM +0200, Carsten Otte wrote:
> [RFC/PATCH 4/5] loop: execute in place (V2)
> The old loop driver in 2.6.11. used the readpage/writepage aops to
> transfer data. Now loop can also use read/write and direct_IO on the
> file if readpage/writepage are not available. Unlike the old 2.6.11.
> version, today's loop driver does work with files that do not have
> readpage/writepage. Threrefore, this patch is optional.
> This patch adds one more transport method to loop that uses the new
> address space operation get_xip_page if available.
>
> This patch is unchanged from previous version.

This should be ifdef'ed to avoid bloat for non-XIP builds. Or just be dropped
completely. How much difference does it make over read/write and where does
loop performance matter?