From: Corey Minyard <minyard@acm.org>
To: Lee Revell <rlrevell@joe-job.com>
Cc: george@mvista.com, Andrew Morton <akpm@osdl.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fixes for IPMI use of timers
Date: Fri, 20 May 2005 21:00:15 -0500 [thread overview]
Message-ID: <428E962F.40600@acm.org> (raw)
In-Reply-To: <1116639005.14582.7.camel@mindpipe>
Lee Revell wrote:
>On Fri, 2005-05-20 at 18:14 -0700, George Anzinger wrote:
>
>
>>> /* We already have irqsave on, so no need for it
>>> here. */
>>>- read_lock(&xtime_lock);
>>>+ read_lock_irqsave(&xtime_lock, flags);
>>>
>>>
>>I rather hope this fails to compile :) xtime_lock is a sequence lock in the 2.6
>>kernel.
>>
>>
>>
>>> jiffies_now = jiffies;
>>> smi_info->si_timer.expires = jiffies_now;
>>> smi_info->si_timer.sub_expires = get_arch_cycles(jiffies_now);
>>>+ read_unlock_irqrestore(&xtime_lock, flags);
>>>
>>>
>
>The old code clearly has an unbalanced lock/unlock, maybe it's
>sufficient to just fix that?
>
>
Yes, probably just best to fix that up. When high-res timers make it
into the kernel, this can be fixed up, this is left over from the 2.4
high-res timers.
-Corey
prev parent reply other threads:[~2005-05-21 2:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 23:30 [PATCH] Fixes for IPMI use of timers Corey Minyard
2005-05-19 23:51 ` Lee Revell
2005-05-20 2:20 ` Corey Minyard
2005-05-21 1:14 ` George Anzinger
2005-05-21 1:30 ` Lee Revell
2005-05-21 2:00 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428E962F.40600@acm.org \
--to=minyard@acm.org \
--cc=akpm@osdl.org \
--cc=george@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rlrevell@joe-job.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox