Re: [PATCH rc4-mm2 2/2] posix-timers: use try_to_del_timer_sync()

[George Anzinger <george@mvista.com>]

Andrew Morton wrote:
> George Anzinger <george@mvista.com> wrote:
> 
>>Oleg Nesterov wrote:
>>
>>>sys_timer_settime/sys_timer_delete needs to delete k_itimer->real.timer
>>>synchronously while holding ->it_lock, which is also locked in posix_timer_fn.
>>>
>>>This patch removes timer_active/set_timer_inactive which plays with
>>>timer_list's internals in favour of using try_to_del_timer_sync(),
>>>which was introduced in the previous patch.
>>
>>Is there a particular reason for this, like it does not work, for example, or 
>>are you just trying to clean up code?
> 
> 
> The posix-timers code is poking about in the internals of the timer_list
> implementation.  It shouldn't, and finding some way to fix that up is
> desirable.

I see, and agree.  Could you give me a bit to work on this.  I would like to 
come up with something that is compatable with the HRT patch.  At this time I am 
waiting for John Stultz's time keeping changes to get in before pushing HRT, but 
I would still like it to get it into the kernel.



-- 
George Anzinger   george@mvista.com
High-res-timers:  http://sourceforge.net/projects/high-res-timers/