public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bill Davidsen <davidsen@tmr.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	davem@davemloft.net, jmorris@redhat.com
Subject: Re: [CRYPTO]: Only reschedule if !in_atomic()
Date: Tue, 24 May 2005 09:32:02 -0400	[thread overview]
Message-ID: <42932CD2.3040204@tmr.com> (raw)
In-Reply-To: <20050523193116.62844826.akpm@osdl.org>

Andrew Morton wrote:
> Herbert Xu <herbert@gondor.apana.org.au> wrote:
> 
>>Perhaps we should code this into the crypto API instead? For instance,
>> we can have a tfm flag that says whether we can sleep or not.
> 
> 
> Are you sure it's actually needed? Have significant scheduling latencies
> actually been observed?
> 
> Bear in mind that anyone who cares a lot about latency will be running
> CONFIG_PREEMPT kernels, in which case the whole thing is redundant anyway. 
> I generally take the position that if we're going to put a scheduling point
> into a non-premept kernel then it'd better be for a pretty bad latency
> point - more than 10 milliseconds, say.
> 
People do run crypto on old slow machines, and also laptops configured 
to use as little power as possible. I wouldn't be surprised if latencies 
got in the >10ms range pretty regularly on some systems which are pretty 
mainstream.

Just my read on it, if a flag will prevent deadlock without relying on 
callers doing the right thing, that's probably a desirable change WRT 
future stability.

  parent reply	other threads:[~2005-05-24 13:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200505232300.j4NN07lE012726@hera.kernel.org>
2005-05-23 23:28 ` [CRYPTO]: Only reschedule if !in_atomic() Andrew Morton
2005-05-23 23:58   ` Benjamin Herrenschmidt
2005-05-24  0:24     ` Andrew Morton
2005-05-24  2:21   ` Herbert Xu
2005-05-24  2:31     ` Andrew Morton
2005-05-24  2:43       ` Herbert Xu
2005-05-24  3:20         ` James Morris
2005-05-24  3:50           ` Herbert Xu
2005-05-24 13:32       ` Bill Davidsen [this message]
     [not found]     ` <20050523.193612.08320356.davem@davemloft.net>
2005-05-24  3:47       ` Herbert Xu
2005-05-24  6:40 ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42932CD2.3040204@tmr.com \
    --to=davidsen@tmr.com \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=jmorris@redhat.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox