The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Alejandro Bonilla <abonilla@linuxwireless.org>
To: randy_dunlap <rdunlap@xenotime.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Creating patches for source
Date: Thu, 26 May 2005 20:48:22 -0500	[thread overview]
Message-ID: <42967C66.1070700@linuxwireless.org> (raw)
In-Reply-To: <20050526193437.2fd71090.rdunlap@xenotime.net>

randy_dunlap wrote:

>On Thu, 26 May 2005 20:21:43 -0500 Alejandro Bonilla wrote:
>
>| Hi,
>| 
>|     Quick and fast question here. I'm starting to create patches (diff) 
>| :-) so, I googled for a while and most say that one could use the diff 
>| -up or diff -Naur. They both look to me very similar and honestly -up 
>| works for me. Still, what command will make the cleanest patch and which 
>| one is mostly used?
>
>You looked at 'man diff', right?
>  
>
Yes.

>and linux/Documentation/SubmittingPatches, which says:
>Use "diff -up" or "diff -uprN" to create patches.
>  
>
well, the "or" doesn't tells me the that there is a best way. That's the 
deal.

>So you use the options that are appropriate for your patches.
>
>If you are patching only one file (or a few files in the same
>directory), -up is usually fine.
>  
>
Excelent.

>If you have patches in multiple directories and you want diff
>to search in subdirectories for patches, you need to use -r
>(recursive).
>If you are adding new files, you need to use -N.
>  
>
Adding new files into the whole source? Like it will  make a patch with 
the full content and then create the file when patching the source? 
Thanks for that one, sounds like I will need to use it.

>Is there a specific problem that you are trying to solve?
>  
>
I was just patching a README :-) and the patch looked too big and/or 
bulky, so I noticed it was using a lot of lines from the document, but I 
was only changing a single letter in a word. i.e. I changed/added 20 
letters in total, and the patch is like 200 words.

I think it's just me being a paranoid patch-newbie.

Thanks,

.Alejandro

>---
>~Randy
>
>  
>


      reply	other threads:[~2005-05-27  2:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-27  1:21 Creating patches for source Alejandro Bonilla
2005-05-27  2:34 ` randy_dunlap
2005-05-27  1:48   ` Alejandro Bonilla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42967C66.1070700@linuxwireless.org \
    --to=abonilla@linuxwireless.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox