public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Trivial module unload problem in 2.6.12-rc5[-mm1]
@ 2005-05-28 19:17 Keith Moore
  0 siblings, 0 replies; only message in thread
From: Keith Moore @ 2005-05-28 19:17 UTC (permalink / raw)
  To: Linux Kernel Mailing List

I've found a trivial module unload problem in the 2.6.12-rc5 and (-mm1)
kernels.

net/ipv4/multipath_drr.c can cause an oops soon after unloading. Its
module init routine calls multipath_alg_register() with the incorrect
IP_MP_ALG_RR value, but its module exit routine calls
multipath_alg_deregister() with the *correct* IP_MP_ALG_DRR value.

Easy fix:

--- linux-2.6.12-rc5-mm1/net/ipv4/multipath_drr.c.old	2005-05-28
15:03:24.000000000 +0200
+++ linux-2.6.12-rc5-mm1/net/ipv4/multipath_drr.c	2005-05-28
15:03:31.000000000 +0200
@@ -244,7 +244,7 @@ static int __init drr_init(void)
 	if (err)
 		return err;

-	err = multipath_alg_register(&drr_ops, IP_MP_ALG_RR);
+	err = multipath_alg_register(&drr_ops, IP_MP_ALG_DRR);
 	if (err)
 		goto fail;


Thanks,
KM


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-05-28 19:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-28 19:17 Trivial module unload problem in 2.6.12-rc5[-mm1] Keith Moore

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox