public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Keenan Pepper <keenanpepper@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: ACPI fan problems on HP pavilion desktop
Date: Sat, 28 May 2005 15:54:42 -0400	[thread overview]
Message-ID: <4298CC82.9010901@gmail.com> (raw)

I'm trying to set up cpu clock modulation and ACPI fan support on my HP pavilion
a302x, so it runs quieter when it's not doing anything (the fan is pretty loud).
The cpufreq driver works great, but the ACPI fan driver not so good: it can turn
the fan off but not back on again.

I changed these lines in drivers/acpi/power.c:

-       if (resource->state != ACPI_POWER_RESOURCE_STATE_OFF)
-               return_VALUE(-ENOEXEC);
+       if (resource->state != ACPI_POWER_RESOURCE_STATE_OFF) {
+               ACPI_DEBUG_PRINT((ACPI_DB_WARN,
+                       "Device [%s] says it's still on", resource->name));
+               resource->state = ACPI_POWER_RESOURCE_STATE_OFF;
+       }

and now I can turn the fan off and on again, so it works for me, but I want to
figure out what's actually wrong so other people trying to run linux on this
machine can have it Just Work(tm) for them. Is it just buggy hardware that
doesn't comply with the ACPI spec? If so, is there some place where all the
workarounds for hardware quirks are collected?

Keenan Pepper


             reply	other threads:[~2005-05-28 19:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-28 19:54 Keenan Pepper [this message]
2005-05-29 12:45 ` ACPI fan problems on HP pavilion desktop Len Brown
  -- strict thread matches above, loose matches on Subject: below --
2005-05-27 20:38 Keenan Pepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4298CC82.9010901@gmail.com \
    --to=keenanpepper@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox