From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2725351-1516672256-2-9618907254372739002 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, FREEMAIL_FORGED_FROMDOMAIN 0.25, FREEMAIL_FROM 0.001, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='utf-8' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516672256; b=LrYd3RUnlzfOur/6TqF8T24mznlJ9X7BYlHrYFFId3nW/sj t+ft4PeO0IJHlP8nIvS/VcMlSVJgpPAJdScyTmYkwYXuoYxPV5H0LTKWzkbp/hUX 5hxaYxfuhvyvmKgZu8+traHheZwo232rrVDcQiuk0i9Rcvy+XTJw9JiKM8au9lbW hec4CKnSJd+V12uR/oOa2uxJjeFmfK9rHpzO6GegX/PCNoI0dje3pxgdGNfpkAbu JUYBCraWeA4IZV5Rxqskq36ZRpKW6C7eU0LJlzBwb0VYoqoZ9GAm7PFese7Sydj2 nawsJZ9eA5/ePQtOHOdPz+4uHDs7DgjchpZR8/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:to:cc:references:from:message-id :date:mime-version:in-reply-to:content-type :content-transfer-encoding:sender:list-id; s=arctest; t= 1516672256; bh=9bWNetsR/6ENjfDKVNuRVT5Xgk3wjmYmy5qyVn+aNg0=; b=u J5KXutueKIb7lJSHvk2a0EzJ13rhhTTyViJLDeJBB8iEXw0Qp8EoQMUi+uBvp6P8 i/Dabzs3bySEp+TP20t4e4CBPDJ3p0x/GHZAMz04q5T9KCZ2ThVAPNs9ZBarJOdl +VopcX8fBmYXXjuEbb91VSnIiesQvkMo98EUgdE2/M26dKdaAnilpIuTvHlIGuKU 3bahfwxGIXZ4VPeqACB49arRNrfL8ayw3vWG3dHHh3bYtMSrVXK6fvucHLHuNyDa 0ML9ZV5/XiOHR8DatTq0KWNtHs3pkGPrQdxX3B1dNJhP4vKd0RRV1ljn00M+1wVx C96Qw8PlXq9hm40g3SG7w== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=FKtlpd59 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=fail (body has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=dEQyNcbZ; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=gmail.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=FKtlpd59 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=fail (body has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=dEQyNcbZ; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=gmail.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751137AbeAWBuw (ORCPT ); Mon, 22 Jan 2018 20:50:52 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:40642 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128AbeAWBuv (ORCPT ); Mon, 22 Jan 2018 20:50:51 -0500 X-Google-Smtp-Source: AH8x2256goRz1bjSpSGWdv5yiLJJexo2L7AIZPUy0/Pu+Y3bPfiebqhjjqctnwvUjk0qIlBRVRz3vg== Subject: Re: [PATCH 1/5] USB: serial: f81232: clear overrun flag To: Oliver Neukum , johan@kernel.org Cc: peter_hong@fintek.com.tw, "Ji-Ze Hong (Peter Hong)" , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <1516607927-8887-1-git-send-email-hpeter+linux_kernel@gmail.com> <1516615597.7580.7.camel@suse.com> From: "Ji-Ze Hong (Peter Hong)" Message-ID: <42995e53-a110-a0fa-da47-4ebe35272812@gmail.com> Date: Tue, 23 Jan 2018 09:50:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1516615597.7580.7.camel@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi Oliver, Oliver Neukum 於 2018/1/22 下午 06:06 寫道: >> +static void f81232_lsr_worker(struct work_struct *work) >> +{ >> + struct f81232_private *priv; >> + struct usb_serial_port *port; >> + int status; >> + u8 tmp; >> + >> + priv = container_of(work, struct f81232_private, lsr_work); >> + port = priv->port; >> + >> + status = f81232_get_register(port, LINE_STATUS_REGISTER, &tmp); >> + if (status) >> + dev_warn(&port->dev, "read LSR failed: %d\n", status); >> +} > > Hi, > > I am afraid this is incomplete. You are scheduling a work that does IO. > Hence you must cancel that work when the driver is unbound from the > interface. You must also not do IO like this while the system is suspending. We'll add cancel worker operation on close() and suspend() to prevent from I/O operations in wrong time with next patch version. Thanks -- With Best Regards, Peter Hong