From: Andy Whitcroft <apw@shadowen.org>
To: Valdis.Kletnieks@vt.edu
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.12-rc5-mm1 - missing #define SECTIONS_SHIFT in sparsemem
Date: Mon, 30 May 2005 00:27:19 +0100 [thread overview]
Message-ID: <429A4FD7.5040600@shadowen.org> (raw)
In-Reply-To: <200505282238.j4SMcYdN014990@turing-police.cc.vt.edu>
Valdis.Kletnieks@vt.edu wrote:
> sparsemem-memory-model.patch references SECTIONS_SHIFT without defining it.
>
> Caught this while compiling with -Wundef, causes lots of warnings
> when it gets used in include/linux/mm.h. The appended patch Works For Me,
> although I wonder if the *real* problem isn't a missing '#ifdef CONFIG_SPARSEMEM'
> around the code that uses it in mm.h.
>
> Signed-Off-By: valdis.kletnieks@vt.edu
>
> --- linux-2.6.12-rc5-mm1/include/linux/mmzone.h.ifdef 2005-05-27 15:12:26.000000000 -0400
> +++ linux-2.6.12-rc5-mm1/include/linux/mmzone.h 2005-05-27 16:26:40.000000000 -0400
> @@ -568,6 +568,7 @@ static inline int pfn_valid(unsigned lon
> void sparse_init(void);
> #else
> #define sparse_init() do {} while (0)
> +#define SECTIONS_SHIFT 0
> #endif /* CONFIG_SPARSEMEM */
>
> #ifdef CONFIG_NODES_SPAN_OTHER_NODES
Odd. I guess there must be a reference from an unused function to this
define when SPARSEMEM is off. Can you send me your .config please and
I'll have a look.
-apw
next prev parent reply other threads:[~2005-05-29 23:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-28 22:38 2.6.12-rc5-mm1 - missing #define SECTIONS_SHIFT in sparsemem Valdis.Kletnieks
2005-05-29 23:27 ` Andy Whitcroft [this message]
2005-05-30 16:31 ` Valdis.Kletnieks
2005-05-31 16:02 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=429A4FD7.5040600@shadowen.org \
--to=apw@shadowen.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox