From: Dirk Eibach <dirk.eibach@gdsys.cc>
To: Guenter Roeck <linux@roeck-us.net>
Cc: <linux-kernel@vger.kernel.org>,
Kumar Gala <galak@kernel.crashing.org>,
Wim Van Sebroeck <wim@iguana.be>,
<linux-watchdog@vger.kernel.org>,
<devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH] powerpc: Make Book E watchdog reset type configurable
Date: Thu, 02 May 2013 21:11:19 +0200 [thread overview]
Message-ID: <429ec64cf7c30a139db40eb20fd3e682@gdsys.cc> (raw)
In-Reply-To: <20130502161720.GA7797@roeck-us.net>
Hi Guenter,
>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
>> index e89fc31..6048593 100644
>> --- a/drivers/watchdog/Kconfig
>> +++ b/drivers/watchdog/Kconfig
>> @@ -1172,6 +1172,38 @@ config BOOKE_WDT_DEFAULT_TIMEOUT
>>
>> The value can be overridden by the wdt_period command-line
>> parameter.
>>
>> +choice
>> + prompt "PowerPC Book-E Watchdog reset type"
>> + depends on BOOKE_WDT
>> + default BOOKE_WDT_RESET_CHIP
>> + help
>> + Specify what kind of reset will be executed on watchdog timeout.
>> +
> Seems to me it would be much better to make this configurable via
> platform data
> and/or device tree.
good catch. What do the device-tree gurus think to be a nice property
name?
Cheers
Dirk
next prev parent reply other threads:[~2013-05-02 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 14:45 [PATCH] powerpc: Make Book E watchdog reset type configurable dirk.eibach
2013-05-02 16:17 ` Guenter Roeck
2013-05-02 19:11 ` Dirk Eibach [this message]
2013-05-03 1:17 ` Guenter Roeck
2013-05-03 8:33 ` Dirk Eibach
2013-05-03 13:46 ` Guenter Roeck
2013-05-03 18:30 ` Dirk Eibach
2013-05-03 20:33 ` Guenter Roeck
2013-05-03 15:59 ` Guenter Roeck
2013-05-26 17:04 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=429ec64cf7c30a139db40eb20fd3e682@gdsys.cc \
--to=dirk.eibach@gdsys.cc \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox