From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: axboe@suse.de, James.Bottomley@steeleye.com, bzolnier@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH Linux 2.6.12-rc5-mm2 02/09] blk: make scsi use -EOPNOTSUPP instead of -EIO on ILLEGAL_REQUEST
Date: Sun, 05 Jun 2005 03:10:03 -0400 [thread overview]
Message-ID: <42A2A54B.9070607@pobox.com> (raw)
In-Reply-To: <20050605055337.215AB52C@htj.dyndns.org>
Tejun Heo wrote:
> 02_blk_scsi_eopnotsupp.patch
>
> Use -EOPNOTSUPP instead of -EIO on ILLEGAL_REQUEST.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> scsi_lib.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletion(-)
>
> Index: blk-fixes/drivers/scsi/scsi_lib.c
> ===================================================================
> --- blk-fixes.orig/drivers/scsi/scsi_lib.c 2005-06-05 14:53:32.000000000 +0900
> +++ blk-fixes/drivers/scsi/scsi_lib.c 2005-06-05 14:53:33.000000000 +0900
> @@ -849,7 +849,8 @@ void scsi_io_completion(struct scsi_cmnd
> scsi_requeue_command(q, cmd);
> result = 0;
> } else {
> - cmd = scsi_end_request(cmd, 0, this_count, 1);
> + cmd = scsi_end_request(cmd, -EOPNOTSUPP,
> + this_count, 1);
This looks like a change from zero to EOPNOTSUPP, but your description
says its a change from EIO to EOPNOTSUPP.
Jeff
next prev parent reply other threads:[~2005-06-05 7:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-05 5:57 [PATCH Linux 2.6.12-rc5-mm2 00/09] blk: ordered request reimplementation (take 2, for review) Tejun Heo
2005-06-05 5:57 ` [PATCH Linux 2.6.12-rc5-mm2 01/09] blk: add @uptodate to end_that_request_last() and @error to rq_end_io_fn() Tejun Heo
2005-06-05 5:57 ` [PATCH Linux 2.6.12-rc5-mm2 02/09] blk: make scsi use -EOPNOTSUPP instead of -EIO on ILLEGAL_REQUEST Tejun Heo
2005-06-05 7:10 ` Jeff Garzik [this message]
2005-06-07 1:34 ` Tejun Heo
2005-06-05 5:57 ` [PATCH Linux 2.6.12-rc5-mm2 03/09] blk: make ide use -EOPNOTSUPP instead of -EIO on ABRT_ERR Tejun Heo
2005-06-05 5:57 ` [PATCH Linux 2.6.12-rc5-mm2 04/09] blk: separate out bio init part from __make_request Tejun Heo
2005-06-05 5:57 ` [PATCH Linux 2.6.12-rc5-mm2 05/09] blk: reimplement handling of barrier request Tejun Heo
2005-06-05 5:57 ` [PATCH Linux 2.6.12-rc5-mm2 06/09] blk: update SCSI to use the new blk_ordered Tejun Heo
2005-06-05 7:08 ` Jeff Garzik
2005-06-07 1:58 ` Tejun Heo
2005-06-05 5:57 ` [PATCH Linux 2.6.12-rc5-mm2 07/09] blk: update libata " Tejun Heo
2005-06-05 7:02 ` Jeff Garzik
2005-06-07 2:11 ` Tejun Heo
2005-06-05 5:57 ` [PATCH Linux 2.6.12-rc5-mm2 08/09] blk: update IDE " Tejun Heo
2005-06-05 6:47 ` Jeff Garzik
2005-06-05 14:14 ` Bartlomiej Zolnierkiewicz
2005-06-07 2:26 ` Tejun Heo
2005-06-05 5:57 ` [PATCH Linux 2.6.12-rc5-mm2 09/09] blk: debug messages Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42A2A54B.9070607@pobox.com \
--to=jgarzik@pobox.com \
--cc=James.Bottomley@steeleye.com \
--cc=axboe@suse.de \
--cc=bzolnier@gmail.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox