Re: sata_promise driver and 2.6.11 on a MIPS board

Re: sata_promise driver and 2.6.11 on a MIPS board

[Jeff Garzik]

Jim Ramsay wrote:
> The driver then waits via a wait_for_completion apparently waiting for
> the PCI card to throw an interrupt so it can continue.  However, I
> never see this interrupt generated, and the driver code waits forever.


This is a known bug that definitely needs fixing:

(to ATA developers)
Any time an ATA command is issued outside of the SCSI layer, we need to 
employ a timer to time out commands.

Since most commands are done within the SCSI layer, which provides a lot 
of error handling apparatus, most commands properly time out.  The ones 
during probe - IDENTIFY DEVICE, set xfer mode, etc. - do not have such a 
timer.

	Jeff

Re: sata_promise driver and 2.6.11 on a MIPS board

[Jim Ramsay]

On 6/6/05, Jeff Garzik <jgarzik@pobox.com> wrote:
> Jim Ramsay wrote:
> > The driver then waits via a wait_for_completion apparently waiting for
> > the PCI card to throw an interrupt so it can continue.  However, I
> > never see this interrupt generated, and the driver code waits forever.
> 
> 
> This is a known bug that definitely needs fixing:
> 
> (to ATA developers)
> Any time an ATA command is issued outside of the SCSI layer, we need to
> employ a timer to time out commands.
> 
> Since most commands are done within the SCSI layer, which provides a lot
> of error handling apparatus, most commands properly time out.  The ones
> during probe - IDENTIFY DEVICE, set xfer mode, etc. - do not have such a
> timer.

So is this an issue with the sata_promise.c driver, or the
libata-core.c?  Which one should implement the timeout?

What would you suggest as a workaround or a proper fix?

-- 
Jim Ramsay
"Me fail English?  That's unpossible!"