Re: [PATCH Linux 2.6.12-rc5-mm2 02/09] blk: make scsi use -EOPNOTSUPP instead of -EIO on ILLEGAL_REQUEST

Tejun Heo
2005-06-07T01:35:10Z

Jeff Garzik wrote:
> Tejun Heo wrote:
>
>> 02_blk_scsi_eopnotsupp.patch
>>
>> Use -EOPNOTSUPP instead of -EIO on ILLEGAL_REQUEST.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>>
>> scsi_lib.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletion(-)
>>
>> Index: blk-fixes/drivers/scsi/scsi_lib.c
>> ===================================================================
>> --- blk-fixes.orig/drivers/scsi/scsi_lib.c 2005-06-05
>> 14:53:32.000000000 +0900
>> +++ blk-fixes/drivers/scsi/scsi_lib.c 2005-06-05 14:53:33.000000000
>> +0900
>> @@ -849,7 +849,8 @@ void scsi_io_completion(struct scsi_cmnd
>> scsi_requeue_command(q, cmd);
>> result = 0;
>> } else {
>> - cmd = scsi_end_request(cmd, 0, this_count, 1);
>> + cmd = scsi_end_request(cmd, -EOPNOTSUPP,
>> + this_count, 1);
>
>
> This looks like a change from zero to EOPNOTSUPP, but your description
> says its a change from EIO to EOPNOTSUPP.
>
> Jeff
>

Hello, Jeff.

I just found it confusing to write changing 0 to -EOPNOTSUPP when 0
actually means -EIO (uptodate). I'll write in more detailed way next time.

Thank you. :-)

--
tejun