From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] get_user_pages: kill get_page_map
Date: Tue, 07 Jun 2005 23:41:20 +1000 [thread overview]
Message-ID: <42A5A400.90003@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.61.0506062054170.5000@goblin.wat.veritas.com>
Hugh Dickins wrote:
> Since its birth, get_user_pages has been calling a misguided get_page_map
> function. follow_page has already returned NULL if the pfn is invalid,
> we cannot reach an invalid pfn from a validated struct page.
>
> Remove get_page_map, and the messy rewind in get_user_pages to cope with
> its failure. Oh, and could we please call that "struct page *page" like
> everywhere else, instead of "struct page *map"?
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
This is the same as the one I've had around (from you, of course)
for ages. Been through a fair bit of testing here, and I like it.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
prev parent reply other threads:[~2005-06-07 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-06 19:55 [PATCH] get_user_pages: kill get_page_map Hugh Dickins
2005-06-06 22:21 ` Andrew Morton
2005-06-07 13:41 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42A5A400.90003@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox