Re: [patch] preempt-trace.patch (mono preempt-trace)

Ingo Molnar
2005-08-05T20:11:34Z

* Andrew Morton <akpm@osdl.org> wrote:

> > please enable CONFIG_FRAME_POINTERS!
>
> Seems a bit tricky. Wouldn't it be best if enabling
> CONFIG_DEBUG_PREEMPT autoselected CONFIG_KALLSYMS_ALL,
> CONFIG_FRAME_POINTER and whatever else we need?

ok, agreed:

-----
when DEBUG_PREEMPT is enabled, select FRAME_POINTER and KALLSYMS_ALL
as well, to make the debug output more useful.

Signed-off-by: Ingo Molnar <mingo@elte.hu>

lib/Kconfig.debug | 3 +++
1 files changed, 3 insertions(+)

Index: linux-preempt-trace/lib/Kconfig.debug
===================================================================
--- linux-preempt-trace.orig/lib/Kconfig.debug
+++ linux-preempt-trace/lib/Kconfig.debug
@@ -70,6 +70,9 @@ config DEBUG_PREEMPT
bool "Debug preemptible kernel"
depends on DEBUG_KERNEL && PREEMPT
default y
+ select FRAME_POINTER
+ select KALLSYMS
+ select KALLSYMS_ALL
help
If you say Y here then the kernel will use a debug variant of the
commonly used smp_processor_id() function and will print warnings