From: Julien TINNES <julien-lkml@cr0.org>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
akpm@osdl.org, julien.tinnes@francetelecom.com,
linux-kernel@vger.kernel.org
Subject: Re: potential-null-pointer-dereference-in-amiga-serial-driver.patch added to -mm tree
Date: Thu, 09 Jun 2005 11:31:06 +0200 [thread overview]
Message-ID: <42A80C5A.1030908@cr0.org> (raw)
In-Reply-To: <20050603075816.GA9922@logos.cnet>
[-- Attachment #1: Type: text/plain, Size: 146 bytes --]
> OK - so better just remove the check. Julien, care to follow Greg's
> recommendation and refresh the patch?
Here it is.
--
Julien TINNES
[-- Attachment #2: 2.6-amiserial-nocheck.patch --]
[-- Type: text/x-patch, Size: 560 bytes --]
--- linux-2.6.11.orig/drivers/char/amiserial.c 2005-05-17 10:55:03.000000000 +0200
+++ linux-2.6.11/drivers/char/amiserial.c 2005-06-09 11:29:04.000000000 +0200
@@ -867,7 +867,7 @@
if (serial_paranoia_check(info, tty->name, "rs_put_char"))
return;
- if (!tty || !info->xmit.buf)
+ if (!info->xmit.buf)
return;
local_irq_save(flags);
@@ -916,7 +916,7 @@
if (serial_paranoia_check(info, tty->name, "rs_write"))
return 0;
- if (!tty || !info->xmit.buf || !tmp_buf)
+ if (!info->xmit.buf || !tmp_buf)
return 0;
local_save_flags(flags);
prev parent reply other threads:[~2005-06-09 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200505310909.j4V98xBR008727@shell0.pdx.osdl.net>
2005-05-31 15:49 ` potential-null-pointer-dereference-in-amiga-serial-driver.patch added to -mm tree Alexey Dobriyan
2005-05-31 12:22 ` Marcelo Tosatti
2005-06-02 5:21 ` Greg KH
2005-06-03 7:58 ` Marcelo Tosatti
2005-06-09 9:31 ` Julien TINNES [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42A80C5A.1030908@cr0.org \
--to=julien-lkml@cr0.org \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=julien.tinnes@francetelecom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox