From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org
Cc: Linas Vepstas <linas@austin.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
long <tlnguyen@snoqualmie.dp.intel.com>,
linux-pci@atrey.karlin.mff.cuni.cz,
linuxppc64-dev <linuxppc64-dev@ozlabs.org>
Subject: [PATCH 04/10] IOCHK interface for I/O error handling/detecting
Date: Thu, 09 Jun 2005 21:53:28 +0900 [thread overview]
Message-ID: <42A83BC8.2010500@jp.fujitsu.com> (raw)
In-Reply-To: <42A8386F.2060100@jp.fujitsu.com>
[This is 4 of 10 patches, "iochk-04-register_bridge.patch"]
- Since there could be a (PCI-)bus-error, some kind of error
cannot detected on the device but on its hosting bridge.
So, it is also required to check the bridge's register.
In other words, to check a bus-error correctly, we need to
check both end of the bus, device and its host bridge.
OK, but often bridges are shared by multiple devices, right?
So we need care to handle it... Yes, see next (5 of 10).
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
---
arch/ia64/lib/iomap_check.c | 19 ++++++++++++++++++-
include/asm-ia64/io.h | 1 +
2 files changed, 19 insertions(+), 1 deletion(-)
Index: linux-2.6.11.11/arch/ia64/lib/iomap_check.c
===================================================================
--- linux-2.6.11.11.orig/arch/ia64/lib/iomap_check.c
+++ linux-2.6.11.11/arch/ia64/lib/iomap_check.c
@@ -14,6 +14,7 @@ int iochk_read(iocookie *cookie);
struct list_head iochk_devices;
DEFINE_SPINLOCK(iochk_lock); /* all works are excluded on this lock */
+static struct pci_dev *search_host_bridge(struct pci_dev *dev);
static int have_error(struct pci_dev *dev);
void iochk_init(void)
@@ -29,6 +30,7 @@ void iochk_clear(iocookie *cookie, struc
INIT_LIST_HEAD(&(cookie->list));
cookie->dev = dev;
+ cookie->host = search_host_bridge(dev);
spin_lock_irqsave(&iochk_lock, flag);
list_add(&cookie->list, &iochk_devices);
@@ -43,7 +45,8 @@ int iochk_read(iocookie *cookie)
int ret = 0;
spin_lock_irqsave(&iochk_lock, flag);
- if( cookie->error || have_error(cookie->dev) )
+ if( cookie->error || have_error(cookie->dev)
+ || (cookie->host && have_error(cookie->host)) )
ret = 1;
list_del(&cookie->list);
spin_unlock_irqrestore(&iochk_lock, flag);
@@ -51,6 +54,20 @@ int iochk_read(iocookie *cookie)
return ret;
}
+struct pci_dev *search_host_bridge(struct pci_dev *dev)
+{
+ struct pci_bus *pbus;
+
+ /* there is no bridge */
+ if (!dev->bus->self) return NULL;
+
+ /* find root bus bridge */
+ for (pbus = dev->bus; pbus->parent && pbus->parent->self;
+ pbus = pbus->parent);
+
+ return pbus->self;
+}
+
static int have_error(struct pci_dev *dev)
{
u16 status;
Index: linux-2.6.11.11/include/asm-ia64/io.h
===================================================================
--- linux-2.6.11.11.orig/include/asm-ia64/io.h
+++ linux-2.6.11.11/include/asm-ia64/io.h
@@ -78,6 +78,7 @@ extern unsigned int num_io_spaces;
struct __iocookie {
struct list_head list;
struct pci_dev *dev; /* targeting device */
+ struct pci_dev *host; /* hosting bridge */
unsigned long error; /* error flag */
};
typedef struct __iocookie iocookie;
next prev parent reply other threads:[~2005-06-09 12:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-09 12:39 [PATCH 00/10] IOCHK interface for I/O error handling/detecting Hidetoshi Seto
2005-06-09 12:48 ` [PATCH 01/10] " Hidetoshi Seto
2005-06-09 16:53 ` Greg KH
2005-06-10 10:29 ` Hidetoshi Seto
2005-06-09 12:50 ` [PATCH 02/10] " Hidetoshi Seto
2005-06-09 12:51 ` [PATCH 03/10] " Hidetoshi Seto
2005-06-09 16:57 ` Greg KH
2005-06-10 10:31 ` Hidetoshi Seto
2005-06-09 17:20 ` Matthew Wilcox
2005-06-10 10:31 ` Hidetoshi Seto
2005-06-09 12:53 ` Hidetoshi Seto [this message]
2005-06-09 16:57 ` [PATCH 04/10] " Greg KH
2005-06-09 12:54 ` [PATCH 05/10] " Hidetoshi Seto
2005-06-09 12:56 ` [PATCH 06/10] " Hidetoshi Seto
2005-06-09 12:58 ` [PATCH 07/10] " Hidetoshi Seto
2005-06-09 17:40 ` David Mosberger
2005-06-10 10:29 ` Hidetoshi Seto
2005-06-10 17:25 ` David Mosberger
2005-06-13 6:54 ` Hidetoshi Seto
2005-06-09 13:00 ` [PATCH 08/10] " Hidetoshi Seto
2005-06-09 13:02 ` [PATCH 09/10] " Hidetoshi Seto
2005-06-09 13:04 ` [PATCH 10/10] " Hidetoshi Seto
2005-06-09 16:59 ` [PATCH 00/10] " Greg KH
2005-06-09 17:13 ` Matthew Wilcox
2005-06-09 22:26 ` Benjamin Herrenschmidt
2005-06-10 10:31 ` Hidetoshi Seto
2005-06-10 10:30 ` Hidetoshi Seto
2005-06-09 17:34 ` Matthew Wilcox
2005-06-10 10:32 ` Hidetoshi Seto
2005-06-10 23:25 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42A83BC8.2010500@jp.fujitsu.com \
--to=seto.hidetoshi@jp.fujitsu.com \
--cc=benh@kernel.crashing.org \
--cc=linas@austin.ibm.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc64-dev@ozlabs.org \
--cc=tlnguyen@snoqualmie.dp.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox