Re: [PATCH 03/10] IOCHK interface for I/O error handling/detecting

Hidetoshi Seto
2005-06-10T10:28:12Z

Greg KH wrote:
>> /* definition of ia64 iocookie */
>>-typedef unsigned long iocookie;
>>+struct __iocookie {
>>+ struct list_head list;
>>+ struct pci_dev *dev; /* targeting device */
>>+ unsigned long error; /* error flag */
>>+};
>>+typedef struct __iocookie iocookie;
>
> Hm, why not just make the thing be a "struct iocookie" in the first
> place, then we don't have to mess with a typedef at all. And then each
> arch can define how the structure will look like in their private .c
> files, ensuring that no user can ever try to touch the structure
> themselves.

Aha.., maybe I understand it just now.
I don't know why, but I just stuck to typedef...

Thanks,
H.Seto