public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Fix warning in kernel/module.c
@ 2005-06-09 18:03 Matthew Dobson
  0 siblings, 0 replies; only message in thread
From: Matthew Dobson @ 2005-06-09 18:03 UTC (permalink / raw)
  To: Linux Kernel Mailing List; +Cc: Andrew Morton, Bligh, Martin J.

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

I get this warning compiling 2.6.12-rc6-mm1:

kernel/module.c:404: warning: `modinfo_attrs' defined but not used

The attached patch fixes the warning, which I guess was sort of caused by
me.  I was having compilation problems on -rc5-mm2 and I sent a patch to
move some definitions outside an ifdef.  Now the code only uses those
definitions INSIDE appropriately ifdef'd sections, so we get a warning
about not using them.  Bah.  This should (hopefully) end this.

-Matt

[-- Attachment #2: modinfo_attrs-fix2.patch --]
[-- Type: text/x-patch, Size: 662 bytes --]

--- linux-2.6.12-rc6-mm1/kernel/module.c	2005-06-08 15:22:43.995409432 -0700
+++ linux-2.6.12-rc6-mm1/kernel/module.c.fixed	2005-06-08 15:21:55.286814264 -0700
@@ -370,6 +370,7 @@ static inline void percpu_modcopy(void *
 }
 #endif /* CONFIG_SMP */
 
+#ifdef CONFIG_MODULE_UNLOAD
 #define MODINFO_ATTR(field)	\
 static void setup_modinfo_##field(struct module *mod, const char *s)  \
 {                                                                     \
@@ -407,7 +408,6 @@ static struct module_attribute *modinfo_
 	NULL,
 };
 
-#ifdef CONFIG_MODULE_UNLOAD
 /* Init the unload section of the module. */
 static void module_unload_init(struct module *mod)
 {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-06-09 18:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-09 18:03 Fix warning in kernel/module.c Matthew Dobson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox