Re: [GIT PATCH] Another PCI fix for 2.6.12-rc6

["Narendra Sankar" <nsankar@broadcom.com>]

David S. Miller wrote:

>From: Greg KH <gregkh@suse.de>
>Date: Thu, 9 Jun 2005 15:20:33 -0700
>
>  
>
>>	"Broadcom already submitted the bnx2 driver for the 5706 gigabit
>>	driver which enables MSI on all systems that support PCI-X. That
>>	patch has already gone into 2.6.12-rc6. So if the MSI disable
>>	patch does not get into 2.6.12, anyone who uses the 5706 on the
>>	Serverworks chipset platform, will have interrupt failures."
>>    
>>
>
>The bnx2 driver can get the MSI test added to it just like the tg3
>driver does.  I don't see why the same code wasn't propagated.  Either
>both drivers need that MSI test code, or both do not.
>
>That doesn't make any sense, one testing for correct MSI functionality
>while the other does not.
>
>
>  
>
Hi everyone

The platform quirk is valid for other PCI-X devices that try to enable 
MSI on that Serverworks chipset. When I submitted the msi quirk patch, 
the bnx2 driver did not have the msi check. I guess it got added. 
Different parts of the organization :(.

However the fact that MSI functionality on the GC_LE is broken could 
potentially cause problems with other devices that try to enable MSI. 
This is the only version of the chipset that the functionality is broken 
on. Other variants have working MSI implementations.

So it would still be useful to have this patch in, would it not?

Thanks
Naren Sankar
Broadcom/Serverworks.