From: "Narendra Sankar" <nsankar@broadcom.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: gregkh@suse.de, torvalds@osdl.org, akpm@osdl.org,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [GIT PATCH] Another PCI fix for 2.6.12-rc6
Date: Thu, 09 Jun 2005 15:56:58 -0700 [thread overview]
Message-ID: <42A8C93A.1090809@broadcom.com> (raw)
In-Reply-To: <20050609.155100.93023939.davem@davemloft.net>
David S. Miller wrote:
>From: "Narendra Sankar" <nsankar@broadcom.com>
>Date: Thu, 09 Jun 2005 15:48:28 -0700
>
>
>
>>So it would still be useful to have this patch in, would it not?
>>
>>
>
>Absolutely, the patch should go in.
>
>I just want to make sure the descrepency between the two Broadcom
>drivers gets resolved. TG3 does a MSI correctness check, BNX2
>does not. And this is what doesn't make any sense.
>
>
>
Actually looking at the bnx2.c code from jeffG 2.6.13 git tree, it seems
that it also tests for MSIs being delivered.
So both tg3 and bnx2 test for MSI correctness.
My original comment when submitting the patch, was under the assumption
that these tests were not being done. However that code has got added to
both drivers.
Naren
next prev parent reply other threads:[~2005-06-09 22:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-09 22:20 [GIT PATCH] Another PCI fix for 2.6.12-rc6 Greg KH
2005-06-09 22:21 ` [PATCH] PCI: MSI functionality broken on Serverworks GC chipset Greg KH
2005-06-09 22:31 ` David S. Miller
2005-06-09 22:32 ` [GIT PATCH] Another PCI fix for 2.6.12-rc6 David S. Miller
2005-06-09 22:48 ` Narendra Sankar
2005-06-09 22:51 ` David S. Miller
2005-06-09 22:56 ` Narendra Sankar [this message]
2005-06-09 22:55 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42A8C93A.1090809@broadcom.com \
--to=nsankar@broadcom.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox