From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261728AbVFKO7g (ORCPT ); Sat, 11 Jun 2005 10:59:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261723AbVFKO7g (ORCPT ); Sat, 11 Jun 2005 10:59:36 -0400 Received: from mail-gw.turkuamk.fi ([195.148.208.32]:13702 "EHLO mail-gw.turkuamk.fi") by vger.kernel.org with ESMTP id S261721AbVFKO6T (ORCPT ); Sat, 11 Jun 2005 10:58:19 -0400 Message-ID: <42AAFC75.7090601@kolumbus.fi> Date: Sat, 11 Jun 2005 18:00:05 +0300 From: =?UTF-8?B?TWlrYSBQZW50dGlsw6Q=?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050513 Fedora/1.7.8-1.3.1 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ingo Molnar Cc: Esben Nielsen , Daniel Walker , linux-kernel@vger.kernel.org, sdietrich@mvista.com Subject: Re: [PATCH] local_irq_disable removal References: <1118449247.27756.47.camel@dhcp153.mvista.com> <20050611135111.GB31025@elte.hu> In-Reply-To: <20050611135111.GB31025@elte.hu> X-MIMETrack: Itemize by SMTP Server on marconi.hallinto.turkuamk.fi/TAMK(Release 5.0.13a |April 8, 2004) at 11.06.2005 17:58:16, Serialize by Router on notes.hallinto.turkuamk.fi/TAMK(Release 6.5.4|March 27, 2005) at 11.06.2005 17:58:17, Serialize complete at 11.06.2005 17:58:17 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii; format=flowed Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar wrote: >i've done two more things in the latest patches: > >- decoupled the 'soft IRQ flag' from the hard IRQ flag. There's > basically no need for the hard IRQ state to follow the soft IRQ state. > This makes the hard IRQ disable primitives a bit faster. > >- for raw spinlocks i've reintroduced raw_local_irq primitives again. > This helped get rid of some grossness in sched.c, and the raw > spinlocks disable preemption anyway. It's also safer to just assume > that if a raw spinlock is used together with the IRQ flag that the > real IRQ flag has to be disabled. > >these changes dont really impact scheduling/preemption behavior, they >are cleanup/robustization changes. > > Ingo >- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/ > > > With the soft IRQ flag local_irq_disable() doesn't seem to protect against soft interrupts (via SA_NODELAY interrupt-> invoke_softirq()). Could this be a problem? --Mika